Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 removal #224505

Closed
7 of 8 tasks
LeSuisse opened this issue Apr 3, 2023 · 6 comments · Fixed by #239049
Closed
7 of 8 tasks

PHP 8.0 removal #224505

LeSuisse opened this issue Apr 3, 2023 · 6 comments · Fixed by #239049
Labels
0.kind: enhancement Add something new

Comments

@LeSuisse
Copy link
Contributor

LeSuisse commented Apr 3, 2023

PHP 8.0 will reach end-of-life at the end in November 2023.

This issue is here to track the progress of its removal from nixpkgs.

This affects:

@LeSuisse LeSuisse added the 0.kind: enhancement Add something new label Apr 3, 2023
LeSuisse added a commit to LeSuisse/nixpkgs that referenced this issue Apr 19, 2023
PHP 8.0 will be end-of-life before the end of life of the next stable
version of NixOS. Related to NixOS#224505.
@Atemu
Copy link
Member

Atemu commented Jun 9, 2023

Wouldn't it be better to just mark php80 as "broken" rather than the individual packages?

Ideally, we'd also only mark it broken when lib.isInOldestRelease 2305 which would "automatically" happen before branch-off of 23.11.

I think I might shoot a PR to do this while reverting #232276 so that Grocy can still be used until branch-off. In the mean time, upstream will hopefully have released a PHP 8.1 compatible version (grocy/grocy#2251).

@Atemu
Copy link
Member

Atemu commented Jun 9, 2023

#236904

@LeSuisse
Copy link
Contributor Author

PHP 8.0 will be removed before 23.11 branch off as it will be end of life by then.

Ideally, we'd also only mark it broken when lib.isInOldestRelease 2305 which would "automatically" happen before branch-off of 23.11.

It's the packages that are broken not PHP itself, marking the packages directly is the way to go IMO. It's also make things clear and put them on the path of removal if upstream cannot maintain them to a maintained version of PHP.

@LeSuisse
Copy link
Contributor Author

@sreichel Do you know if there is any chance that a version of n98-magerun compatible with PHP 8.1 will be published soon(ish)? The upstream issue seems to be stalled for the past 2 weeks.

@LeSuisse LeSuisse mentioned this issue Jun 21, 2023
12 tasks
etu pushed a commit that referenced this issue Jun 22, 2023
mccurdyc pushed a commit to mccurdyc/nixpkgs that referenced this issue Jul 3, 2023
@sreichel
Copy link

@LeSuisse @cmuench i cant tell about release plans.

@sreichel
Copy link

sreichel commented Oct 6, 2023

@LeSuisse magerun is nearly ready. There is a v3 dev-release for php81, that just need some improvments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: enhancement Add something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants