Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/moodle: use PHP 8.1 #224491

Merged
merged 1 commit into from
Apr 19, 2023
Merged

nixos/moodle: use PHP 8.1 #224491

merged 1 commit into from
Apr 19, 2023

Conversation

LeSuisse
Copy link
Member

@LeSuisse LeSuisse commented Apr 3, 2023

Description of changes

Moodle is compatible with PHP 8.1 since the 4.1.2.

https://moodledev.io/general/development/policies/php

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@LeSuisse
nixos/moodle: use PHP 8.1
2b155e1 
Moodle is compatible with PHP 8.1 since the 4.1.2.

https://moodledev.io/general/development/policies/php
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 3, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 3, 2023
@LeSuisse LeSuisse mentioned this pull request Apr 3, 2023
Closed
8 tasks
@RaitoBezarius
Copy link
Member

@ofborg test moodle

@RaitoBezarius RaitoBezarius merged commit 8ef336e into NixOS:master Apr 19, 2023
@LeSuisse LeSuisse deleted the moodle-php-81 branch April 19, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@shyim shyim shyim approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeSuisse @RaitoBezarius @drupol @shyim