Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rizin: init at unstable-2021-01-13 #109305

Closed
wants to merge 1 commit into from
Closed

rizin: init at unstable-2021-01-13 #109305

wants to merge 1 commit into from

Conversation

Pamplemousse
Copy link
Member

Motivation for this change

rizin is a fork of radare2.
And the software powering Cutter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Pamplemousse xav.maso@gmail.com

@Pamplemousse
rizin: init at unstable-2021-01-13
09cfcfe 
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
@Pamplemousse
Copy link
Member Author

Pamplemousse commented Jan 13, 2021 •
edited
Loading

This is a "best effort" to get something out there and gather feedback.

rizin build is meant to be easier than radare's, but I am not sure how well all the features are supported by the current expression.

Cutter will probably need some rework too.

@Pamplemousse
Copy link
Member Author

Poke @makefu , @7c6f434c , @Mic92 .

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 13, 2021
SuperSandro2000
SuperSandro2000 reviewed Jan 14, 2021
View reviewed changes
pkgs/development/tools/analysis/rizin/default.nix
};

postPatch = let
capstone = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to a let in before mkDerivation.

pkgs/development/tools/analysis/rizin/default.nix
Comment on lines +45 to +51
meta = {
description = "unix-like reverse engineering framework and commandline tools";
homepage = "https://rizin.re/";
license = stdenv.lib.licenses.lgpl3Only;
maintainers = with stdenv.lib.maintainers; [ pamplemousse ];
platforms = with stdenv.lib.platforms; linux;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = {
description = "unix-like reverse engineering framework and commandline tools";
homepage = "https://rizin.re/";
license = stdenv.lib.licenses.lgpl3Only;
maintainers = with stdenv.lib.maintainers; [ pamplemousse ];
platforms = with stdenv.lib.platforms; linux;
};
meta = with lib; {
description = "unix-like reverse engineering framework and commandline tools";
homepage = "https://rizin.re/";
license = licenses.lgpl3Only;
maintainers = with maintainers; [ pamplemousse ];
platforms = with platforms; linux;
};

pkgs/development/tools/analysis/rizin/default.nix
@@ -0,0 +1,52 @@
{ stdenv
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv
{ stdenv
, lib

pkgs/development/tools/analysis/rizin/default.nix
sha256 = "0y5g74yjyliciawpn16zhdwya7bd3d7b1cccpcccc2wg8vni1k2w";
};
in ''
mkdir -p build/shlr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mkdir -p build/shlr
mkdir shlr

Mic92
Mic92 reviewed Jan 14, 2021
View reviewed changes
pkgs/development/tools/analysis/rizin/default.nix
repo = "rizin";
rev = "ca2471ae9596176c656f065ed74c480f13784e1b";
sha256 = "0qigy1px0jy74c5ig73dc2fqjcy6vcy76i25dx9r3as6zfpkkaxj";
};
Copy link
Member

@Mic92 Mic92 Jan 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They still rely on git to set versions etc:

https://github.com/rizinorg/rizin/blob/d4964454765539c61cce7f3f845f8d7fe3a3f076/Makefile#L60

In our radare2 build we generate those automatically (see python script).

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109305 run on x86_64-linux 1

1 package built:
  • rizin

@Mic92
Copy link
Member

Mic92 commented Apr 8, 2021

also included in #118041

@Mic92 Mic92 closed this Apr 8, 2021
@Pamplemousse Pamplemousse deleted the rizin branch May 13, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pamplemousse @SuperSandro2000 @Mic92