Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutter: 1.12.0 -> 2.0.0 #118041

Merged
merged 2 commits into from
Apr 8, 2021
Merged

cutter: 1.12.0 -> 2.0.0 #118041

merged 2 commits into from
Apr 8, 2021

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 30, 2021

Motivation for this change

@offlinehacker I propose renaming cutter to tcp-cutter. It is less popular than this https://github.com/rizinorg/cutter,
which was originally named radare2-cutter. Since they no longer part of the radare2 project and now named their own
fork rizin, this no longer holds true.
Having it named tcp-cutter also has the advantage that the package name matches the binary so that nix run just works.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 force-pushed the cutter branch 3 times, most recently from 684c29a to 09cd82b Compare March 30, 2021 11:41
@tnias
Copy link
Contributor

tnias commented Apr 1, 2021

I can build and run it. I tested basic functionality, such as loading a binary, running analysis, scrolling though disassembly/graph/hexdump/string. 👍

This also introduces rizin, which cutter builds on top
@tnias
Copy link
Contributor

tnias commented Apr 2, 2021

Cutter seem to have translations for many languages, but Edit > Preferences > Appearance > Language only offers English.

@tnias
Copy link
Contributor

tnias commented Apr 2, 2021

I packaged a plugin rizin/cutter plugin rz-ghidra.nix. Manually copying the artifacts into one of the search paths works. Search paths are fetched in getPluginDirectories and depend on environment variables that are set in cutters qt application wrapper.

How would I add the plugin in a elegant way? Adding it as a dependency results in an infinite recursion.

@Mic92
Copy link
Member Author

Mic92 commented Apr 8, 2021

I packaged a plugin rizin/cutter plugin rz-ghidra.nix. Manually copying the artifacts into one of the search paths works. Search paths are fetched in getPluginDirectories and depend on environment variables that are set in cutters qt application wrapper.

How would I add the plugin in a elegant way? Adding it as a dependency results in an infinite recursion.

There could be a wrapper around cutter that sets CUTTER_EXTRA_PLUGIN_DIRS to the plugins you specified.

@Mic92 Mic92 merged commit 034c49f into NixOS:master Apr 8, 2021
@Mic92 Mic92 deleted the cutter branch April 8, 2021 10:32
@Mic92
Copy link
Member Author

Mic92 commented Apr 8, 2021

Regarding translations: https://github.com/rizinorg/cutter/blob/3a32ea741e58284e295b72d4cb38bf829ff0d43b/cmake/Translations.cmake#L31
Maybe qt does not look in the right directories? Not sure how this normally works?

@Mic92
Copy link
Member Author

Mic92 commented Apr 8, 2021

might need XDG_DATA_DIRS: #37741 (comment)

@Mic92 Mic92 mentioned this pull request Apr 8, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants