seaweedfs: add version check to passthru.tests

[raboof]

Motivation for this change

This is basically the extent of testing I usually do when an upgrade
is proposed, so this takes that manual step away.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[SuperSandro2000]

Would it be easy to test actually functionality?

[raboof]

Would it be easy to test actually functionality?

No ;)

Converting to draft because nix-community/nixpkgs-update#260 (comment) mentioned passthru.tests might be a better place for this than installCheckPhase, so I want to check that out.

[raboof]

Updated to use passthru.tests. The diff looks more scary than it is because the indentation changed.

[raboof]

Result of nixpkgs-review pr 119636 run on x86_64-linux 1

[raboof]

let's discuss whether this check belongs in installCheckPhase or in passthru.tests in #119731 (comment) first

[davidak]

It does belong in passthru.tests as it was discussed earlier (#73076). Today i finally documented it (#120534)!

I would like to have a general, reusable test for this specific case.

[raboof]

I would like to have a general, reusable test for this specific case.

Me, too - but I figured I'd first "test the waters" with a specific test before generalizing to a reusable one.

[davidak]

generally looks good

[davidak]

hmm, not sure if i'm doing something wrong or if nixpkgs-review has issues

[davidak@gaming:~/code/nixpkgs]$ nix run -f channel:nixos-unstable nixpkgs-review -c nixpkgs-review pr --post-result --token ***** 119636 -p seaweedfs.tests
[16.7 MiB DL]
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0 pull/119636/head:refs/nixpkgs-review/1
remote: Enumerating objects: 1629, done.
remote: Counting objects: 100% (865/865), done.
remote: Compressing objects: 100% (18/18), done.
remote: Total 1629 (delta 853), reused 849 (delta 847), pack-reused 764
Receiving objects: 100% (1629/1629), 1.13 MiB | 2.68 MiB/s, done.
Resolving deltas: 100% (1157/1157), completed with 362 local objects.
From https://github.com/NixOS/nixpkgs
   5d41312d331..14f65f0dc59  master                -> refs/nixpkgs-review/0
 + 88535b695c3...4fe52810ad5 refs/pull/119636/head -> refs/nixpkgs-review/1  (forced update)
$ git worktree add /home/davidak/.cache/nixpkgs-review/pr-119636/nixpkgs 14f65f0dc595d132a4ec6f9e6cd604e04d0a2033
Preparing worktree (detached HEAD 14f65f0dc59)
Updating files: 100% (25651/25651), done.
HEAD is now at 14f65f0dc59 Merge pull request #116365 from omasanori/sage-9.3
$ nix-env --option system x86_64-linux -f /home/davidak/.cache/nixpkgs-review/pr-119636/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit --no-ff 4fe52810ad52f6af84531727204d9f636f3cec46
Automatic merge went well; stopped before committing as requested
$ nix-env --option system x86_64-linux -f /home/davidak/.cache/nixpkgs-review/pr-119636/nixpkgs -qaP --xml --out-path --show-trace --meta
error: cannot coerce a set to a string

       at /nix/store/pazb6bdswz7g84pm801zx7pigbpcw9l7-nixpkgs-review-2.6.0/lib/python3.8/site-packages/nixpkgs_review/nix/evalAttrs.nix:12:35:

           11|     pkg = lib.attrByPath attrPath null pkgs;
           12|     maybePath = builtins.tryEval "${pkg}";
             |                                   ^
           13|   in rec {
nix --experimental-features nix-command --system x86_64-linux eval --json --impure --expr (import /nix/store/pazb6bdswz7g84pm801zx7pigbpcw9l7-nixpkgs-review-2.6.0/lib/python3.8/site-packages/nixpkgs_review/nix/evalAttrs.nix /tmp/tmpzg1rbnza) failed to run, /tmp/tmpzg1rbnza was stored inspection
https://github.com/NixOS/nixpkgs/pull/119636 failed to build
$ git worktree prune

@raboof did the test run for you?

[SuperSandro2000]

@ofborg test seaweedfs

[raboof]

@raboof did the test run for you?

Yes, and nixpkgs-review happy here as well (installed system-wide rather than using flakes though)

[raboof]

Result of nixpkgs-review pr 119636 run on x86_64-linux 1

[davidak]

It seem to be a problem with nixpkgs-review.

I checked out the pr and build it with nix-build.

[davidak@gaming:~/code/nixpkgs]$ gh pr checkout 119636
From github.com:NixOS/nixpkgs
 * [new ref]                 refs/pull/119636/head -> seaweedfs-add-install-check
Switched to branch 'seaweedfs-add-install-check'

[davidak@gaming:~/code/nixpkgs]$ nix-build -A seaweedfs.tests
these derivations will be built:
  /nix/store/j559rivz4dr3km6k8cfaj69mfc3pvvxp-weed-version.drv
these paths will be fetched (11.69 MiB download, 56.34 MiB unpacked):
  /nix/store/q7ggrlf02ycdn23d235589l59pll699q-seaweedfs-2.36
copying path '/nix/store/q7ggrlf02ycdn23d235589l59pll699q-seaweedfs-2.36' from 'https://cache.nixos.org'...
building '/nix/store/j559rivz4dr3km6k8cfaj69mfc3pvvxp-weed-version.drv'...
version 30GB 2.36  linux amd64
/nix/store/g4i2iwx9ray8mgfs77m7m37nmvviz01r-weed-version

[davidak@gaming:~/code/nixpkgs]$ ll /nix/store/g4i2iwx9ray8mgfs77m7m37nmvviz01r-weed-version
-r--r--r-- 1 root root 0 Jan  1  1970 /nix/store/g4i2iwx9ray8mgfs77m7m37nmvviz01r-weed-version

The result is an empty file in the nix store. Perfect.

[davidak]

Looks good

test works