test-utilities: version test #121896
Merged
test-utilities: version test #121896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
force-pushed
the
extract-version-test-to-utility
branch
from
88dbc60
to
95a5897
Compare
ofborg
bot
added
10.rebuild-darwin: 0
roberth
reviewed
May 6, 2021
raboof
force-pushed
the
extract-version-test-to-utility
branch
from
95a5897
to
ea2d1cb
Compare
roberth
reviewed
May 6, 2021
raboof
force-pushed
the
extract-version-test-to-utility
branch
from
ea2d1cb
to
d374a01
Compare
roberth
reviewed
May 6, 2021
| { package, | ||
| command ? "${package.pname or package.name} --version", | ||
| version ? package.version, | ||
| }: runCommand "test-version" { buildInputs = [ package ]; meta.timeout = 60; } '' |
There was a problem hiding this comment.
Suggested change
| }: runCommand "test-version" { buildInputs = [ package ]; meta.timeout = 60; } '' | |
| }: runCommand "test-version" { nativeBuildInputs = [ package ]; meta.timeout = 60; } '' |
buildInputs is for components (linking etc) and not for running. With cross compilation and in the future with strictDeps, these components will not be added to PATH.
@Ericson2314 do you think it's feasible to send this to a remote builder in case of cross compilation? Do we an attribute à la pkgs.buildPackages for this purpose? (I've tried hostP{ackages,*}, remoteP*, testP*)
You'd need a remote builder, but that's better than not being able to run this at all.
raboof
force-pushed
the
extract-version-test-to-utility
branch
from
d374a01
to
e195ed2
Compare
OPNA2608
reviewed
May 6, 2021
raboof
force-pushed
the
extract-version-test-to-utility
branch
from
e195ed2
to
a22412f
Compare
roberth
reviewed
May 6, 2021
Extract 'version test' to a reusable test utility as discussed in NixOS#119636 (comment) and
raboof
force-pushed
the
extract-version-test-to-utility
branch
from
a22412f
to
b68130f
Compare
roberth
approved these changes
May 7, 2021
11 tasks
12 tasks
0x4A6F
reviewed
Nov 20, 2021
|
Haven't seen this until now. This is awesome. Thank you very much! ✨ |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/improve-the-jdk-infrastructure-on-nixpkgs/45678/33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make adding version tests more likely by making it easier, as
discussed in #119636 (comment)
Long-term I hope 'upstreaming' the tests could replace the functionality
in nixpkgs-update as discussed in
nix-community/nixpkgs-update#260
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)