Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnetCorePackages.*_5*: 5.0.0 -> 5.0.6 #125736

Closed
wants to merge 3 commits into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 4, 2021

Motivation for this change

closes: #125735
closes: #112582

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Jun 4, 2021

Result of nixpkgs-review pr 125736 at 30a5a5af run on x86_64-linux 1

8 packages failed to build:
4 packages built successfully:
  • dotnet-sdk_5 (dotnetCorePackages.sdk_5_0)
  • dotnetCorePackages.aspnetcore_5_0
  • jellyfin
  • jetbrains.rider

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 125736 at 804bde8 run on aarch64-linux 1

5 packages failed to build:
4 packages built successfully:
  • dotnet-sdk_5 (dotnetCorePackages.sdk_5_0)
  • dotnetCorePackages.aspnetcore_5_0
  • dotnetCorePackages.net_5_0
  • opentabletdriver

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

osu-lazer works. Maybe also need to re-generate deps of roslyn?

@IvarWithoutBones
Copy link
Member

Could the deps of Ryujinx be regenerated as well? That should fix the current build failure.

@jonringer
Copy link
Contributor Author

Even after regenerating them, they still seem to fail

@oxalica
Copy link
Contributor

oxalica commented Jun 7, 2021

@jonringer Do you use the updated dotnet SDK to regenerate it? The update script will pick it from your system by default.

@jonringer
Copy link
Contributor Author

@jonringer Do you use the updated dotnet SDK to regenerate it? The update script will pick it from your system by default.

I believe I did NIX_PATH=nixpkgs=$PWD but I'll try again today

@ratsclub
Copy link
Member

ratsclub commented Jun 8, 2021

I'm waiting this PR to update the fsharp package to the latest release. As far as I know it depends on dotnet 5.0.300 so I'm not sure if the package fsharp41 will continue to work.

@jonringer
Copy link
Contributor Author

Maybe as a compromise, I can merged this to staging-next, and we can just stabilize there?

@jonringer
Copy link
Contributor Author

current status:

8 packages failed to build:
fsharp41 github-runner msbuild omnisharp-roslyn python-language-server roslyn ryujinx wasabibackend

14 packages built:
btcpayserver dotnet-sdk_3 dotnet-sdk_5 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.aspnetcore_5_0 dotnetCorePackages.net_5_0 dotnetCorePackages.netcore_3_1 jellyfin jetbrains.rider nbxplorer opentabletdriver osu-lazer radarr vscode-extensions.ms-vsliveshare.vsliveshare

@ratsclub
Copy link
Member

ratsclub commented Jun 8, 2021

About fsharp41: #126262

@avdv
Copy link
Member

avdv commented Sep 14, 2021

Also note #136329 - maybe this fixes the build for omnisharp-roslyn on top of this?

@avdv
Copy link
Member

avdv commented Sep 14, 2021

I have locally upgraded dotnet 5 to 5.0.9 / 5.0.400.

Current status:

6 packages failed to build:
discordchatexporter-cli github-runner osu-lazer python-language-server ryujinx wasabibackend

19 packages built:
ArchiSteamFarm azure-functions-core-tools btcpayserver depotdownloader dotnet-sdk_3 dotnet-sdk_5 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.aspnetcore_5_0 dotnetCorePackages.net_5_0 dotnetCorePackages.netcore_3_1 jellyfin jetbrains.rider msbuild nbxplorer omnisharp-roslyn opentabletdriver radarr roslyn vscode-extensions.ms-vsliveshare.vsliveshare

update: ryujinx also builds after updating the dependencies.

@avdv
Copy link
Member

avdv commented Sep 15, 2021

I also updated dotnet 3.1* to the latest version.

Current status:

1 package failed to build:
github-runner

24 packages built:
ArchiSteamFarm azure-functions-core-tools btcpayserver depotdownloader discordchatexporter-cli dotnet-sdk_3 dotnet-sdk_5 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.aspnetcore_5_0 dotnetCorePackages.net_5_0 dotnetCorePackages.netcore_3_1 jellyfin jetbrains.rider msbuild nbxplorer omnisharp-roslyn opentabletdriver osu-lazer python-language-server radarr roslyn ryujinx vscode-extensions.ms-vsliveshare.vsliveshare wasabibackend

But the github-runner package builds successfully in isolation, only failed with a test failure within nixpkgs-review...

@jonringer my updated branch is here: https://github.com/avdv/nixpkgs/tree/bump-dotnet Feel free to incorporate it into your PR, or should I just open a new one?

@avdv
Copy link
Member

avdv commented Sep 15, 2021

Seems like I can do dotnet 5.0.9 -> 5.0.10 now: https://github.com/dotnet/core/blob/main/release-notes/5.0/5.0.10/5.0.10.md

@avdv
Copy link
Member

avdv commented Sep 16, 2021

I did upgrade to 5.0.10 too. New branch is here: https://github.com/avdv/nixpkgs/tree/bump-dotnet_take-2

Result of nixpkgs-review run on x86_64-linux 1

25 packages built:
  • ArchiSteamFarm
  • azure-functions-core-tools
  • btcpayserver
  • depotdownloader
  • discordchatexporter-cli
  • dotnet-sdk_3
  • dotnet-sdk_5
  • dotnetCorePackages.aspnetcore_3_1
  • dotnetCorePackages.aspnetcore_5_0
  • dotnetCorePackages.net_5_0
  • dotnetCorePackages.netcore_3_1
  • github-runner
  • jellyfin
  • jetbrains.rider
  • msbuild
  • nbxplorer
  • omnisharp-roslyn
  • opentabletdriver
  • osu-lazer
  • python-language-server
  • radarr
  • roslyn
  • ryujinx
  • vscode-extensions.ms-vsliveshare.vsliveshare
  • wasabibackend

@avdv
Copy link
Member

avdv commented Sep 17, 2021

FYI, I have just created a new PR with my changes: #138296

@jonringer
Copy link
Contributor Author

#138296 was merged

@jonringer jonringer closed this Sep 17, 2021
@jonringer jonringer deleted the bump-dotnet branch September 17, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnetCorePackages.net_5_0 is out of date, and out of sync with sdk_5_0
6 participants