-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnetCorePackages.*_5*: 5.0.0 -> 5.0.6 #125736
Conversation
Result of 8 packages failed to build:4 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 5 packages failed to build:4 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osu-lazer
works. Maybe also need to re-generate deps of roslyn
?
Could the deps of |
Even after regenerating them, they still seem to fail |
@jonringer Do you use the updated dotnet SDK to regenerate it? The update script will pick it from your system by default. |
I believe I did |
I'm waiting this PR to update the |
Maybe as a compromise, I can merged this to |
current status:
|
About fsharp41: #126262 |
Also note #136329 - maybe this fixes the build for omnisharp-roslyn on top of this? |
I have locally upgraded dotnet 5 to 5.0.9 / 5.0.400. Current status:
update: ryujinx also builds after updating the dependencies. |
I also updated dotnet 3.1* to the latest version. Current status:
But the github-runner package builds successfully in isolation, only failed with a test failure within nixpkgs-review... @jonringer my updated branch is here: https://github.com/avdv/nixpkgs/tree/bump-dotnet Feel free to incorporate it into your PR, or should I just open a new one? |
Seems like I can do dotnet 5.0.9 -> 5.0.10 now: https://github.com/dotnet/core/blob/main/release-notes/5.0/5.0.10/5.0.10.md |
I did upgrade to 5.0.10 too. New branch is here: https://github.com/avdv/nixpkgs/tree/bump-dotnet_take-2 Result of 25 packages built:
|
FYI, I have just created a new PR with my changes: #138296 |
#138296 was merged |
Motivation for this change
closes: #125735
closes: #112582
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)