dotnetCorePackages.*_5*: 5.0.0 -> 5.0.10 #138296
Conversation
The old version of the script tried to parse the output of the dotnet tool, but apparently, that output changed and thus the list of dependencies was empty.
There was a problem hiding this comment.
We should probably make a proper way to automatically update the sdks, however this PR LGTM
https://github.com/NixOS/nixpkgs/pull/138296
24 packages built:
azure-functions-core-tools btcpayserver depotdownloader discordchatexporter-cli dotnet-sdk_3 dotnet-sdk_5 dotnetCorePackages.aspnetcore_3_1 dotnetCorePackages.aspnetcore_5_0 dotnetCorePackages.net_5_0 dotnetCorePackages.netcore_3_1 github-runner jellyfin jetbrains.rider msbuild nbxplorer omnisharp-roslyn opentabletdriver osu-lazer python-language-server radarr roslyn ryujinx vscode-extensions.ms-vsliveshare.vsliveshare wasabibackend
Yes, definitely. Will look into how to at least consolidate all the different create-deps scripts... when I find some time. Also, trying to create a backport of this PR... if nobody beats me to it. |
| @@ -1,13 +1,26 @@ | |||
| #! /usr/bin/env nix-shell | |||
| #! nix-shell -i bash -p dotnet-sdk_3 nixfmt | |||
| #! nix-shell -i bash -p dotnet-sdk_3 jq xmlstarlet curl nixfmt | |||
There was a problem hiding this comment.
Please use nixpkgs-fmt. nixfmt enforces stupidly short lines.
| for package in * | ||
| do | ||
| cd "$package" | ||
| for version in * | ||
| do | ||
| found=false | ||
| for repo in "${repos[@]}" | ||
| do |
There was a problem hiding this comment.
Generally google style bash is preferred.
for x in y; do
There was a problem hiding this comment.
Yeah, I prefer that too; just copied that from somewhere else... Hope to fix all these things and use nuget-to-nix instead of all the different things done in those scripts.
Motivation for this change
Upgrades to the latest .NET release, supersedes #125736
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)