Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiv2: 0.27.3 -> 0.27.4 #127172

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Conversation

paperdigits
Copy link
Contributor

@paperdigits paperdigits commented Jun 17, 2021

Motivation for this change

Update exiv2 patches all known security issues and adds support for reading Canon CR3 files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions
Copy link
Contributor

Successfully created backport PR #128675 for release-21.05.

@sikmir
Copy link
Member

sikmir commented Jun 29, 2021

Broken on darwin.

@mweinelt
Copy link
Member

Broken on darwin.

Needs more information.

@sikmir
Copy link
Member

sikmir commented Jun 29, 2021

Broken on darwin.

Needs more information.

[ERROR] The output of the testcase mismatch the reference
[INFO] The output has been saved to file /private/var/folders/wf/qxrs82v946n91pb5s71n3dy80000gp/T/nix-build-exiv2-0.27.4.drv-0/source/test/tmp/conversions.out
[INFO] simply_diff:
/private/var/folders/wf/qxrs82v946n91pb5s71n3dy80000gp/T/nix-build-exiv2-0.27.4.drv-0/source/test/data/conversions.out: 204 lines
/private/var/folders/wf/qxrs82v946n91pb5s71n3dy80000gp/T/nix-build-exiv2-0.27.4.drv-0/source/test/tmp/conversions.out: 214 lines
The first mismatch is in line 46:
< Xmp.exif.UserComment                         LangAlt     1  lang="x-default" This is a JIS encoded Exif user comment. Or was it?
> Warning: Charset conversion required but no character mapping functionality available.

----------------------------------------------------------------------
Ran 24 tests in 37.348s

FAILED (errors=1)
make[3]: *** [CMakeFiles/tests.dir/build.make:76: CMakeFiles/tests] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants