[Backport release-21.05] exiv2: 0.27.3 -> 0.27.4 #128675

github-actions · 2021-06-29T21:13:14Z

Bot-based backport to release-21.05, triggered by a label in #127172.

Before merging, ensure that this backport complies with the Criteria for Backporting.
- Even as a non-commiter, if you find that it does not comply, leave a comment.

(cherry picked from commit 492e221)

sikmir · 2021-06-29T21:15:19Z

Broken on darwin.

jonringer · 2021-06-30T06:29:50Z

Broken on darwin.

does it work on master? this is just a backport

jonringer · 2021-06-30T06:31:09Z

hmm, that would be a regression: https://hydra.nixos.org/eval/1682611?filter=exiv2&compare=1682518&full=#tabs-still-succeed

r-rmcgibbo · 2021-06-30T10:44:24Z

Result of nixpkgs-review pr 128675 at d946178 run on aarch64-linux 1

1 package marked as broken and skipped:

photoflow

3 packages failed to build:

111 packages skipped due to time constraints:

calligra
darktable
digikam
geeqie
gimp (gimpPlugins.gimp)
gimpPlugins.gimplensfun
gimpPlugins.gmic (glimpsePlugins.gmic)
glimpse (glimpsePlugins.gimp)
glimpsePlugins.gimplensfun
gmic-qt-krita
...

48 packages built successfully:

cataract
cataract-unstable
doodle
exiv2
gegl_0_4 (gnome.gegl_0_4)
gexiv2 (gnome.gexiv2)
gnome.file-roller
gnome.gnome-books
gnome.gnome-color-manager
gnome.gnome-user-share
gnome.nautilus
gnome.nautilus-python
tracker-miners (gnome.tracker-miners)
gpscorrelate
kgx
libextractor
libsForQt5.baloo (libsForQt515.baloo ,plasma5Packages.baloo)
libsForQt5.baloo-widgets (libsForQt515.baloo-widgets ,plasma5Packages.baloo-widgets)
libsForQt5.kde-cli-tools (libsForQt515.kde-cli-tools ,plasma5Packages.kde-cli-tools)
libsForQt5.kdegraphics-thumbnailers (libsForQt515.kdegraphics-thumbnailers ,plasma5Packages.kdegraphics-thumbnailers)
libsForQt5.kfilemetadata (libsForQt515.kfilemetadata ,plasma5Packages.kfilemetadata)
libsForQt5.kfind (libsForQt515.kfind ,plasma5Packages.kfind)
libsForQt5.krohnkite (libsForQt515.krohnkite ,plasma5Packages.krohnkite)
libsForQt5.kwin-dynamic-workspaces (libsForQt515.kwin-dynamic-workspaces ,plasma5Packages.kwin-dynamic-workspaces)
libsForQt5.kwin-tiling (libsForQt515.kwin-tiling ,plasma5Packages.kwin-tiling)
libsForQt5.libkexiv2 (libsForQt515.libkexiv2 ,plasma5Packages.libkexiv2)
libsForQt5.parachute (libsForQt515.parachute ,plasma5Packages.parachute)
libsForQt5.plasma-workspace (libsForQt515.plasma-workspace ,plasma5Packages.plasma-workspace)
libsForQt5.systemsettings (libsForQt515.systemsettings ,plasma5Packages.systemsettings)
libsForQt512.libkexiv2
libsForQt514.baloo
libsForQt514.baloo-widgets
libsForQt514.kdegraphics-thumbnailers
libsForQt514.kfilemetadata
libsForQt514.kfind
libsForQt514.libkexiv2
pantheon.elementary-greeter
pantheon.extra-elementary-contracts
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-with-indicators
python38Packages.py3exiv2
python39Packages.py3exiv2
rapid-photo-downloader
variety
viewnior
vimiv-qt

2 suggestions:

warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/libraries/exiv2/default.nix:94:0:
```
   |
94 |     description = "A library and command-line utility to manage image metadata";
   | ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/exiv2/default.nix:97:5:
```
   |
97 |     maintainers = [ ];
   |     ^
```

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 128675 at d946178 run on x86_64-linux 1

1 package marked as broken and skipped:

vdrPlugins.xineliboutput

3 packages failed to build:

140 packages skipped due to time constraints:

calligra
darktable
digikam
dropbox-cli
geeqie
gimp (gimpPlugins.gimp)
gimp-with-plugins
gimpPlugins.exposureBlend
gimpPlugins.farbfeld
gimpPlugins.fourier
...

49 packages built successfully:

cataract
cataract-unstable
doodle
exiv2
gegl_0_4 (gnome.gegl_0_4)
gexiv2 (gnome.gexiv2)
gnome.file-roller
gnome.gnome-books
gnome.gnome-color-manager
gnome.gnome-user-share
gnome.nautilus
gnome.nautilus-python
tracker-miners (gnome.tracker-miners)
gpscorrelate
kgx
libextractor
libsForQt5.baloo (libsForQt515.baloo ,plasma5Packages.baloo)
libsForQt5.baloo-widgets (libsForQt515.baloo-widgets ,plasma5Packages.baloo-widgets)
libsForQt5.kde-cli-tools (libsForQt515.kde-cli-tools ,plasma5Packages.kde-cli-tools)
libsForQt5.kdegraphics-thumbnailers (libsForQt515.kdegraphics-thumbnailers ,plasma5Packages.kdegraphics-thumbnailers)
libsForQt5.kfilemetadata (libsForQt515.kfilemetadata ,plasma5Packages.kfilemetadata)
libsForQt5.kfind (libsForQt515.kfind ,plasma5Packages.kfind)
libsForQt5.krohnkite (libsForQt515.krohnkite ,plasma5Packages.krohnkite)
libsForQt5.kwin-dynamic-workspaces (libsForQt515.kwin-dynamic-workspaces ,plasma5Packages.kwin-dynamic-workspaces)
libsForQt5.kwin-tiling (libsForQt515.kwin-tiling ,plasma5Packages.kwin-tiling)
libsForQt5.libkexiv2 (libsForQt515.libkexiv2 ,plasma5Packages.libkexiv2)
libsForQt5.parachute (libsForQt515.parachute ,plasma5Packages.parachute)
libsForQt5.plasma-workspace (libsForQt515.plasma-workspace ,plasma5Packages.plasma-workspace)
libsForQt5.systemsettings (libsForQt515.systemsettings ,plasma5Packages.systemsettings)
libsForQt512.libkexiv2
libsForQt514.baloo
libsForQt514.baloo-widgets
libsForQt514.kdegraphics-thumbnailers
libsForQt514.kfilemetadata
libsForQt514.kfind
libsForQt514.libkexiv2
pantheon.elementary-greeter
pantheon.extra-elementary-contracts
pantheon.switchboard-plug-pantheon-shell
pantheon.switchboard-with-plugs
pantheon.wingpanel-applications-menu
pantheon.wingpanel-with-indicators
pdf2djvu
python38Packages.py3exiv2
python39Packages.py3exiv2
rapid-photo-downloader
variety
viewnior
vimiv-qt

2 suggestions:

warning: no-python-tests
Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
Near pkgs/development/libraries/exiv2/default.nix:94:0:
```
   |
94 |     description = "A library and command-line utility to manage image metadata";
   | ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/libraries/exiv2/default.nix:97:5:
```
   |
97 |     maintainers = [ ];
   |     ^
```

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

risicle · 2021-06-30T22:16:43Z

Is there a good reason to bump stable with this?

ajs124 · 2021-07-01T10:59:05Z

@risicle yes, security issues

risicle · 2021-07-01T19:08:41Z

Ah I see - I saw the existing patches being removed and assumed they were security patches and this bump was just replacing them with a real release...

risicle · 2021-07-03T21:02:04Z

macos 10.15:

======================================================================
ERROR: conversions_test (testcases.TestCases)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/private/tmp/nix-build-exiv2-0.27.4.drv-0/source/tests/bash_tests/testcases.py", line 243, in conversions_test
    BT.reportTest('conversions', out)
  File "/private/tmp/nix-build-exiv2-0.27.4.drv-0/source/tests/bash_tests/utils.py", line 565, in reportTest
    raise RuntimeError('\n' + log.to_str())
RuntimeError: 
[INFO] #1 Convert Exif ImageDescription to XMP x-default langAlt value
[INFO] #2 Convert XMP x-default langAlt value back to Exif ImageDescription
[INFO] #3 Convert XMP single non-x-default langAlt value to Exif ImageDescription
[INFO] #4 This shouldn't work: No x-default, more than one language
[INFO] #5 Add a default language to the XMP file and convert to Exif and IPTC
[INFO] #6 Convert an Exif user comment to XMP
[INFO] #7 And back to Exif
[INFO] #8 Convert IPTC keywords to XMP
[INFO] #9 And back to IPTC
[INFO] #10 Convert an Exif tag to an XMP text value
[INFO] #11 And back to Exif
[INFO] #12 Convert an IPTC dataset to an XMP text value
[INFO] #13 And back to IPTC
[INFO] #14 Convert a few other tags of interest from Exif/IPTC to XMP
[INFO] #15 And back to Exif/IPTC
[INFO] #16 https://github.com/Exiv2/exiv2/issues/521
[ERROR] The output of the testcase mismatch the reference
[INFO] The output has been saved to file /private/tmp/nix-build-exiv2-0.27.4.drv-0/source/test/tmp/conversions.out
[INFO] simply_diff:
/private/tmp/nix-build-exiv2-0.27.4.drv-0/source/test/data/conversions.out: 204 lines
/private/tmp/nix-build-exiv2-0.27.4.drv-0/source/test/tmp/conversions.out: 214 lines
The first mismatch is in line 46:
< Xmp.exif.UserComment                         LangAlt     1  lang="x-default" This is a JIS encoded Exif user comment. Or was it?
> Warning: Charset conversion required but no character mapping functionality available.

----------------------------------------------------------------------
Ran 24 tests in 52.815s

The "error" seems to consist of a bunch of instances of the message Warning: Charset conversion required but no character mapping functionality available. being smattered throughout the output.

risicle · 2021-07-03T22:14:06Z

And as with seemingly everything today it can be solved by adding libiconv to buildInputs. Though this fix should probably be sent to master before it makes its way back here.

Curious why this package uses propagatedBuildInputs for its other dependencies.

risicle · 2021-07-17T23:47:01Z

Don't think this meant to get closed. Just cherry-picking now..

(cherry picked from commit 698d433)

risicle · 2021-07-18T00:54:33Z

Ok that seems to have dealt with it on macos 10.15 for me.

risicle · 2021-08-05T18:09:28Z

Checked this still builds, macos 10.15 & nixos x86_64...

exiv2: 0.27.3 -> 0.27.4

d946178

(cherry picked from commit 492e221)

github-actions bot mentioned this pull request Jun 29, 2021

exiv2: 0.27.3 -> 0.27.4 #127172

Merged

11 tasks

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Jun 29, 2021

risicle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jul 3, 2021

risicle mentioned this pull request Jul 17, 2021

exiv2: fix for darwin #130453

Merged

11 tasks

SuperSandro2000 closed this in #130453 Jul 17, 2021

risicle reopened this Jul 17, 2021

exiv2: fix for darwin by providing libiconv

fb831da

(cherry picked from commit 698d433)

risicle approved these changes Jul 18, 2021

View reviewed changes

risicle merged commit 733682c into release-21.05 Aug 5, 2021

risicle deleted the backport-127172-to-release-21.05 branch August 5, 2021 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport release-21.05] exiv2: 0.27.3 -> 0.27.4 #128675

[Backport release-21.05] exiv2: 0.27.3 -> 0.27.4 #128675

github-actions bot commented Jun 29, 2021

sikmir commented Jun 29, 2021

jonringer commented Jun 30, 2021

jonringer commented Jun 30, 2021

r-rmcgibbo commented Jun 30, 2021 •

edited

Loading

risicle commented Jun 30, 2021

ajs124 commented Jul 1, 2021

risicle commented Jul 1, 2021

risicle commented Jul 3, 2021 •

edited

Loading

risicle commented Jul 3, 2021

risicle commented Jul 17, 2021

risicle commented Jul 18, 2021

risicle commented Aug 5, 2021

[Backport release-21.05] exiv2: 0.27.3 -> 0.27.4 #128675

[Backport release-21.05] exiv2: 0.27.3 -> 0.27.4 #128675

Conversation

github-actions bot commented Jun 29, 2021

sikmir commented Jun 29, 2021

jonringer commented Jun 30, 2021

jonringer commented Jun 30, 2021

r-rmcgibbo commented Jun 30, 2021 • edited Loading

risicle commented Jun 30, 2021

ajs124 commented Jul 1, 2021

risicle commented Jul 1, 2021

risicle commented Jul 3, 2021 • edited Loading

risicle commented Jul 3, 2021

risicle commented Jul 17, 2021

risicle commented Jul 18, 2021

risicle commented Aug 5, 2021

r-rmcgibbo commented Jun 30, 2021 •

edited

Loading

risicle commented Jul 3, 2021 •

edited

Loading