Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixUnstable: 2.5pre20211007 -> 2.5pre20211126 #147376

Merged
merged 1 commit into from
Nov 28, 2021
Merged

nixUnstable: 2.5pre20211007 -> 2.5pre20211126 #147376

merged 1 commit into from
Nov 28, 2021

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Nov 25, 2021 •
edited
Loading

Motivation for this change
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra November 25, 2021 16:25
@Artturin
Copy link
Member Author

nix-eval-jobs doesn't build @Mic92 @adisbladis

nix-eval-jobs> unpacking sources
nix-eval-jobs> unpacking source archive /nix/store/wndp1lpb7g9gs3fmh4pjmqw80pjiw606-source
nix-eval-jobs> source root is source
nix-eval-jobs> patching sources
nix-eval-jobs> configuring
nix-eval-jobs> meson flags: --buildtype=plain         --libdir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/lib --libexecdir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/libexec         --bindir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/bin --sbindir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/sbin         --includedir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/include         --mandir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/share/man--infodir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/share/info         --localedir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1
nix-eval-jobs> The Meson build system
nix-eval-jobs> Version: 0.57.1
nix-eval-jobs> Source dir: /build/source
nix-eval-jobs> Build dir: /build/source/build
nix-eval-jobs> Build type: native build
nix-eval-jobs> Project name: nix-eval-jobs
nix-eval-jobs> Project version: 0.1.6
nix-eval-jobs> C++ compiler for the host machine: g++ (gcc 10.3.0 "g++ (GCC) 10.3.0")
nix-eval-jobs> C++ linker for the host machine: g++ ld.bfd 2.35.2
nix-eval-jobs> Host machine cpu family: x86_64
nix-eval-jobs> Host machine cpu: x86_64
nix-eval-jobs> Found pkg-config: /nix/store/zm7d9fw403racbfyprb4hqlwbwz8544n-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
nix-eval-jobs> Run-time dependency nix-main found: YES 2.5pre20211125_1d2dbbb
nix-eval-jobs> Run-time dependency nix-store found: YES 2.5pre20211125_1d2dbbb
nix-eval-jobs> Run-time dependency nix-expr found: YES 2.5pre20211125_1d2dbbb
nix-eval-jobs> Run-time dependency threads found: YES
nix-eval-jobs> Run-time dependency nlohmann_json found: YES 3.10.2
nix-eval-jobs> Run-time dependency Boost found: YES 1.69.0 (/nix/store/v14bqrnwvgs7r8x5x6l55gajplzlb96p-boost-1.69.0-dev)
nix-eval-jobs> Build targets in project: 1
nix-eval-jobs> Found ninja-1.10.2 at /nix/store/p8x0kw8vb5m74ddm7vzpan7hmwwflbsm-ninja-1.10.2/bin/ninja
nix-eval-jobs> meson: enabled parallel building
nix-eval-jobs> building
nix-eval-jobs> build flags: -j22 -l22
nix-eval-jobs> [1/2] Compiling C++ object src/nix-eval-jobs.p/nix-eval-jobs.cc.o
nix-eval-jobs> FAILED: src/nix-eval-jobs.p/nix-eval-jobs.cc.o
nix-eval-jobs> g++ -Isrc/nix-eval-jobs.p -Isrc -I../src -I/nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix -I/nix/store/76mpr3rwfbbijmjnwkk3bcajfkqanrjb-boehm-gc-8.0.6-dev/include -I/nix/store/v14bqrnwvgs7r8x5x6l55gajplzlb96p-boost-1.69.0-dev/include -I/nix/store/xqrdd2vahf1mi2ww0dwbs181x8rkpxbd-nlohmann_json-3.10.2/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -pthread -DBOOST_ALL_NO_LIB -std=c++17 -std=c++17 -std=c++17 -std=c++17 -fvisibility=hidden -MD -MQ src/nix-eval-jobs.p/nix-eval-jobs.cc.o -MF src/nix-eval-jobs.p/nix-eval-jobs.cc.o.d -o src/nix-eval-jobs.p/nix-eval-jobs.cc.o -c ../src/nix-eval-jobs.cc
nix-eval-jobs> ../src/nix-eval-jobs.cc:32:8: warning: base class 'struct nix::MixEvalArgs' has accessible non-virtual destructor [-Wnon-virtual-dtor]
nix-eval-jobs>    32 | struct MyArgs : MixEvalArgs, MixCommonArgs
nix-eval-jobs>       |        ^~~~~~
nix-eval-jobs> ../src/nix-eval-jobs.cc:32:8: warning: base class 'class nix::MixCommonArgs' has accessible non-virtual destructor [-Wnon-virtual-dtor]
nix-eval-jobs> ../src/nix-eval-jobs.cc:32:8: warning: 'struct MyArgs' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
nix-eval-jobs> ../src/nix-eval-jobs.cc: In function 'void worker(nix::EvalState&, nix::Bindings&, nix::AutoCloseFD&, nix::AutoCloseFD&, const Path&)':
nix-eval-jobs> ../src/nix-eval-jobs.cc:191:72: error: no matching function for call to 'printValueAsJSON(nix::EvalState&, bool, nix::Value&,std::stringstream&, nix::PathSet&)'
nix-eval-jobs>   191 |                   printValueAsJSON(state, true, *metaValue, ss, context);
nix-eval-jobs>       |                                                                        ^
nix-eval-jobs> In file included from ../src/nix-eval-jobs.cc:20:
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:13:6: note: candidate: 'void nix::printValueAsJSON(nix::EvalState&, bool, nix::Value&, const nix::Pos&, nix::JSONPlaceholder&, nix::PathSet&)'
nix-eval-jobs>    13 | void printValueAsJSON(EvalState & state, bool strict,
nix-eval-jobs>       |      ^~~~~~~~~~~~~~~~
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:13:6: note:   candidate expects 6 arguments, 5 provided
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:16:6: note: candidate: 'void nix::printValueAsJSON(nix::EvalState&, bool, nix::Value&, const nix::Pos&, std::ostream&, nix::PathSet&)'
nix-eval-jobs>    16 | void printValueAsJSON(EvalState & state, bool strict,
nix-eval-jobs>       |      ^~~~~~~~~~~~~~~~
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:16:6: note:   candidate expects 6 arguments, 5 provided
nix-eval-jobs> ninja: build stopped: subcommand failed.

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Nov 25, 2021
@Mic92
nix-eval-jobs: switch to nix stable
856ce74 
This also should make prevent breakages like NixOS#147376
@Mic92 Mic92 mentioned this pull request Nov 25, 2021
Merged
13 tasks
@Mic92
Copy link
Member

Mic92 commented Nov 25, 2021

nix-eval-jobs doesn't build @Mic92 @adisbladis

nix-eval-jobs> unpacking sources
nix-eval-jobs> unpacking source archive /nix/store/wndp1lpb7g9gs3fmh4pjmqw80pjiw606-source
nix-eval-jobs> source root is source
nix-eval-jobs> patching sources
nix-eval-jobs> configuring
nix-eval-jobs> meson flags: --buildtype=plain         --libdir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/lib --libexecdir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/libexec         --bindir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/bin --sbindir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/sbin         --includedir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/include         --mandir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/share/man--infodir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/share/info         --localedir=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/pa8kr05sf59s131vpi1qajp8yxzsxlhl-nix-eval-jobs-0.0.1
nix-eval-jobs> The Meson build system
nix-eval-jobs> Version: 0.57.1
nix-eval-jobs> Source dir: /build/source
nix-eval-jobs> Build dir: /build/source/build
nix-eval-jobs> Build type: native build
nix-eval-jobs> Project name: nix-eval-jobs
nix-eval-jobs> Project version: 0.1.6
nix-eval-jobs> C++ compiler for the host machine: g++ (gcc 10.3.0 "g++ (GCC) 10.3.0")
nix-eval-jobs> C++ linker for the host machine: g++ ld.bfd 2.35.2
nix-eval-jobs> Host machine cpu family: x86_64
nix-eval-jobs> Host machine cpu: x86_64
nix-eval-jobs> Found pkg-config: /nix/store/zm7d9fw403racbfyprb4hqlwbwz8544n-pkg-config-wrapper-0.29.2/bin/pkg-config (0.29.2)
nix-eval-jobs> Run-time dependency nix-main found: YES 2.5pre20211125_1d2dbbb
nix-eval-jobs> Run-time dependency nix-store found: YES 2.5pre20211125_1d2dbbb
nix-eval-jobs> Run-time dependency nix-expr found: YES 2.5pre20211125_1d2dbbb
nix-eval-jobs> Run-time dependency threads found: YES
nix-eval-jobs> Run-time dependency nlohmann_json found: YES 3.10.2
nix-eval-jobs> Run-time dependency Boost found: YES 1.69.0 (/nix/store/v14bqrnwvgs7r8x5x6l55gajplzlb96p-boost-1.69.0-dev)
nix-eval-jobs> Build targets in project: 1
nix-eval-jobs> Found ninja-1.10.2 at /nix/store/p8x0kw8vb5m74ddm7vzpan7hmwwflbsm-ninja-1.10.2/bin/ninja
nix-eval-jobs> meson: enabled parallel building
nix-eval-jobs> building
nix-eval-jobs> build flags: -j22 -l22
nix-eval-jobs> [1/2] Compiling C++ object src/nix-eval-jobs.p/nix-eval-jobs.cc.o
nix-eval-jobs> FAILED: src/nix-eval-jobs.p/nix-eval-jobs.cc.o
nix-eval-jobs> g++ -Isrc/nix-eval-jobs.p -Isrc -I../src -I/nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix -I/nix/store/76mpr3rwfbbijmjnwkk3bcajfkqanrjb-boehm-gc-8.0.6-dev/include -I/nix/store/v14bqrnwvgs7r8x5x6l55gajplzlb96p-boost-1.69.0-dev/include -I/nix/store/xqrdd2vahf1mi2ww0dwbs181x8rkpxbd-nlohmann_json-3.10.2/include -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -pthread -DBOOST_ALL_NO_LIB -std=c++17 -std=c++17 -std=c++17 -std=c++17 -fvisibility=hidden -MD -MQ src/nix-eval-jobs.p/nix-eval-jobs.cc.o -MF src/nix-eval-jobs.p/nix-eval-jobs.cc.o.d -o src/nix-eval-jobs.p/nix-eval-jobs.cc.o -c ../src/nix-eval-jobs.cc
nix-eval-jobs> ../src/nix-eval-jobs.cc:32:8: warning: base class 'struct nix::MixEvalArgs' has accessible non-virtual destructor [-Wnon-virtual-dtor]
nix-eval-jobs>    32 | struct MyArgs : MixEvalArgs, MixCommonArgs
nix-eval-jobs>       |        ^~~~~~
nix-eval-jobs> ../src/nix-eval-jobs.cc:32:8: warning: base class 'class nix::MixCommonArgs' has accessible non-virtual destructor [-Wnon-virtual-dtor]
nix-eval-jobs> ../src/nix-eval-jobs.cc:32:8: warning: 'struct MyArgs' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
nix-eval-jobs> ../src/nix-eval-jobs.cc: In function 'void worker(nix::EvalState&, nix::Bindings&, nix::AutoCloseFD&, nix::AutoCloseFD&, const Path&)':
nix-eval-jobs> ../src/nix-eval-jobs.cc:191:72: error: no matching function for call to 'printValueAsJSON(nix::EvalState&, bool, nix::Value&,std::stringstream&, nix::PathSet&)'
nix-eval-jobs>   191 |                   printValueAsJSON(state, true, *metaValue, ss, context);
nix-eval-jobs>       |                                                                        ^
nix-eval-jobs> In file included from ../src/nix-eval-jobs.cc:20:
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:13:6: note: candidate: 'void nix::printValueAsJSON(nix::EvalState&, bool, nix::Value&, const nix::Pos&, nix::JSONPlaceholder&, nix::PathSet&)'
nix-eval-jobs>    13 | void printValueAsJSON(EvalState & state, bool strict,
nix-eval-jobs>       |      ^~~~~~~~~~~~~~~~
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:13:6: note:   candidate expects 6 arguments, 5 provided
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:16:6: note: candidate: 'void nix::printValueAsJSON(nix::EvalState&, bool, nix::Value&, const nix::Pos&, std::ostream&, nix::PathSet&)'
nix-eval-jobs>    16 | void printValueAsJSON(EvalState & state, bool strict,
nix-eval-jobs>       |      ^~~~~~~~~~~~~~~~
nix-eval-jobs> /nix/store/za2c4sf50k1kf1yadmwhk9cpjn9iixpf-nix-2.5pre20211125_1d2dbbb-dev/include/nix/value-to-json.hh:16:6: note:   candidate expects 6 arguments, 5 provided
nix-eval-jobs> ninja: build stopped: subcommand failed.

see: #147387

github-actions bot pushed a commit that referenced this pull request Nov 25, 2021
@Mic92 @github-actions
nix-eval-jobs: switch to nix stable
e4b974a 
This also should make prevent breakages like #147376

(cherry picked from commit 856ce74)
@SuperSandro2000
Copy link
Member

@ofborg eval
@ofborg build

@Artturin Artturin changed the title nixUnstable: 2.5pre20211007 -> 2.5pre20211125 nixUnstable: 2.5pre20211007 -> 2.5pre20211126 Nov 28, 2021
@Artturin Artturin merged commit 9818f39 into NixOS:master Nov 28, 2021
@Artturin Artturin deleted the updatenixunstable1 branch November 28, 2021 19:58
@bobrik
Copy link
Contributor

bobrik commented Nov 29, 2021

Looks like aarch64-darwin failed in CI:

And later with the same issue in Hydra:

Is it not considered a blocker?

@Artturin
Copy link
Member Author

;/ why did the tests show gray instead of red

@Artturin Artturin mentioned this pull request Nov 29, 2021
Closed
@samuela
Copy link
Member

samuela commented Nov 29, 2021

I'm on aarch64-darwin, running nixpkgs-review I'm told "Nothing to be built." and it succeeds. Is there something more specific you'd like tested?

@Artturin
Copy link
Member Author

I'm on aarch64-darwin, running nixpkgs-review I'm told "Nothing to be built." and it succeeds. Is there something more specific you'd like tested?

its already been merged so please just pull in a nixpkgs clone and build nixUnstable

@samuela
Copy link
Member

samuela commented Nov 29, 2021

It looks like it's hanging on one of the tests. Here's the full log: https://gist.github.com/samuela/a911336f320c2c0b6da1b6f2537bcf7b. It's been stuck on this test for a number of minutes now and my CPUs are inactive.

mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Nov 29, 2021
@Mic92 @mkg20001
nix-eval-jobs: switch to nix stable
80e4e5a 
This also should make prevent breakages like NixOS#147376
@bobrik
Copy link
Contributor

bobrik commented Nov 29, 2021

I can try bisecting:

Bisecting: 135 revisions left to test after this (roughly 7 steps)

@bobrik
Copy link
Contributor

bobrik commented Nov 29, 2021 

10f9a8e77d504354deafbcf7351a6d46d4528542 is the first bad commit
commit 10f9a8e77d504354deafbcf7351a6d46d4528542
Author: Eelco Dolstra <edolstra@gmail.com>
Date:   Fri Oct 15 16:52:37 2021 +0200

    Add a test for the non-blocking GC

 src/libstore/gc.cc       |  4 ++++
 tests/gc-non-blocking.sh | 33 +++++++++++++++++++++++++++++++++
 tests/local.mk           |  1 +
 3 files changed, 38 insertions(+)
 create mode 100644 tests/gc-non-blocking.sh

cc @edolstra

@Ma27
Copy link
Member

Ma27 commented Nov 29, 2021 •
edited
Loading

As it was the case with nixUnstable being Nix 2.4pre, I added a backport-label now to also give users of stable NixOS a chance to test unstable Nix. In the end the attribute is already called Unstable, so this should be fine IMHO.

EDIT: OK, github only refreshed the status of the PR but didn't show me the messages up until I posted that one. I guess we should wait a bit witht he backprot then :)

@github-actions github-actions bot mentioned this pull request Nov 29, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #147895 for release-21.11.

@Artturin Artturin mentioned this pull request Nov 29, 2021
Open
@bobrik
Copy link
Contributor

bobrik commented Dec 11, 2021

I opened a PR to disable the broken test to get the package working for the most part:

@bobrik bobrik mentioned this pull request Jan 26, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Artturin @Mic92 @SuperSandro2000 @bobrik @samuela @Ma27