Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixUnstable: disable broken test on darwin #150173

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Dec 11, 2021

Motivation for this change

I think the expectation is that unstable would at least build and work for the most part, but the latter is not guaranteed.

Currently it doesn't build.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

I think the expectation is that unstable would at least build
and work for the most part, but the latter is not guaranteed.

Currently it doesn't build.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 11, 2021
@ofborg ofborg bot requested review from edolstra and lovesegfault December 11, 2021 02:36
@Artturin Artturin merged commit 884445b into NixOS:master Dec 11, 2021
@bobrik bobrik deleted the ivan/nix-unstable-working-darwin branch December 11, 2021 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants