Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/geth: fix api check #156220

Merged
merged 1 commit into from
Jan 26, 2022
Merged

nixos/tests/geth: fix api check #156220

merged 1 commit into from
Jan 26, 2022

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Jan 22, 2022

Motivation for this change

This fixes the geth test. Since ethereum/go-ethereum#21686 the chainId API returns an error when the chain is not synced. So use blockNumber as a basic function test.

Things done
  • Built on platform(s)
    • x86_64-linux nix build -f ./nixos/tests/geth.nix
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@B4dM4n
nixos/tests/geth: fix api check
af628f4 
Since ethereum/go-ethereum#21686 the `chainId`
API returns an error when the chain is not synced. So use
`blockNumber` as a basic function test.
@B4dM4n B4dM4n mentioned this pull request Jan 23, 2022
Merged
13 tasks
@B4dM4n B4dM4n requested a review from bachp January 26, 2022 09:59
@bachp bachp merged commit 5374a4a into NixOS:master Jan 26, 2022
@B4dM4n B4dM4n deleted the nixos-tests-geth branch January 26, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp Awaiting requested review from bachp

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B4dM4n @bachp