nixos/tests: add missing tests #156314
Merged
nixos/tests: add missing tests #156314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests from the `nixos/tests` folder were missing in the `all-tests.nix` file. This meant they couldn't be run from the `nixosTests` attribute set and therefore not be linked to their packages.
github-actions
bot
added
the
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
Synthetica9
added
the
6.topic: testing
|
Maybe it's a good occasion to add them to passthru.tests on the corresponding packages? |
|
Yeah, this would be a good time to improve I will push the update soon. |
B4dM4n
requested review from
adisbladis,
mmahut and
RaghavSood
as code owners
|
Links from all packages to the tests are added. Interestingly some packages already referred to tests which were not present in nixpkgs/pkgs/games/teeworlds/default.nix Line 40 in 8f3c7d0 |
maybe ofborg does not label "passthru.tests does not evaluate" as a failure (because most packages don't have one at all) so people don't notice it |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
symphorien
approved these changes
Jan 23, 2022
fgaz
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some tests from the
nixos/testsfolder were missing in theall-tests.nixfile. This meant they couldn't be run from thenixosTestsattribute set and therefore not be linked to their packages.Things done
Build the following tests on
x86_64-linux:Succeeded:
nixosTests.brscan5nixosTests.emacs-daemonnixosTests.hakanixosTests.iscsi-multipath-rootnixosTests.issonixosTests.jenkins-clinixosTests.k3s-single-nodenixosTests.k3s-single-node-dockernixosTests.molly-brownnixosTests.pict-rsnixosTests.resolvnixosTests.rstudio-servernixosTests.rsyncdnixosTests.soapuiFailed:
nixosTests.doh-proxy-rust: fix in nixos/test/doh-proxy-rust: fix failing check #156224nixosTests.fenics: dependency does not compile ( Hydra build )nixosTests.geth: fix in nixos/tests/geth: fix api check #156220nixosTests.mediatomb: fix in nixos/mediatomb: wait for network-online.target + fix test #156232nixosTests.riak: marked as insecurenixosTests.teeworlds: fix in nixos/tests/teeworlds: fix blocking execute calls #156205nixosTests.wine: fix in nixos/tests/wine: fix gecko check and diskSize type #156200sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes