etcher: 1.6.0 -> 1.7.3, downgrade electron to v12

[eliandoran]

Motivation for this change

• the package needed to be updated to the latest upstream version (1.7.3).
• on 1.6.0, as well as 1.7.3 there was a white screen and the application was unusable:

Relevant issues (nixpkgs):

• Balena Etcher is broken #153537

Relevant issues (upstream):

• White screen on Balena Etcher balena-io/etcher#3558
• When I launch Etcher, I get a blank screen. balena-io/etcher#2866
• White background without any GUI elements, when running Etcher balena-io/etcher#3536
• Only seeing white screen on NixOS balena-io/etcher#3675

Things done

• According to a dev from upstream repo, their master branch is not yet ready for the Electron 13, due to breaking changes regarding remote (relevant documentation: https://stackoverflow.com/questions/37884130/electron-remote-is-undefined ). Considering this, changed electron version for etcher from 14 to 12.

• On a master build, it appears that Electron version 12.2.3 is marked EOL. This makes the package “insecure”, however there are no other alternatives at the moment since the issue has to be fixed upstream (see patch: Update electron to v12.2.3 balena-io/etcher#3697 (comment))

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.05 Release Notes (or backporting 21.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[mkg20001]

tested locally, works

I suppose merging is unavoidable as it doesn't seem to work on later electron versions