Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luaPackages.libluv: fix darwin build #167143

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

thefloweringash
Copy link
Member

libluv was recently converted to a pure cmake package and now there's
nothing lua related in the build. However an old workaround to force
linking against lua on darwin remains. Clean this up.

Description of changes

Just trying to fix neovim on aarch64-darwin.

cc @teto who recently touched this in #166162 (2e5732b)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

libluv was recently converted to a pure cmake package and now there's
nothing lua related in the build. However an old workaround to force
linking against lua on darwin remains. Clean this up.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 4, 2022
@teto teto merged commit c8151fe into NixOS:master Apr 4, 2022
@thefloweringash thefloweringash deleted the darwin-libluv branch April 5, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants