-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luarocks-nix: bump #166162
luarocks-nix: bump #166162
Conversation
fixes #163134 |
@doronbehar you should be happy this makes the libluv packaging a bit clearer IMHO. |
as required by neovim master
to avoid the error 'cfg.root_dir is null' see luarocks/luarocks#1161 for details
some linker flags have been added to support declarative treesitter grammars but the justification is fuzzy and it breaks several stuff on nix see NixOS#147658
Thanks a lot @teto for the hard work! Well done. I pushed a few additions to the neovim expression. |
72d210c
to
258fc2b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Remove unneeded cmakeFlags and explain more what is the difference between lua.pkgs.libluv and lua.pkgs.luv.
258fc2b
to
f80b906
Compare
I've just checked with and without your commits, the functional tests start which is what I wanted to make sure.
As far as I am concerned it's ok to merge. If a darwin user could confirm it works, we could merge. |
looks good. Some of the errors come from packages using the wrong lua version I guess |
seems to pass CI on darwin, merging. |
I wanted to hack on neovim but got held up by several things. Trying to address those here while improving lua ecosystem at the same time.
Related:
#80528
#141718
Fixes #163134 .
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes