luaPackages.luv: cleanup build #80528

doronbehar · 2020-02-19T12:01:46Z

Motivation for this change

Enable us to update Luarocks without breaking neovim as in neovim fails to build on master (due to lua / luarocks) #79870, Neovim (luajitPackages.luv) does not install correctly #80704 & neovim install fails with missing libluv.so.1 #81206.
Make luv's build less hacky, clearer and more maintainable.

Things done

Remove passthru of libluv which was always too confusing IMO - I think I understand the original motivation behind that but I don't think it's worth the maintenance / confusion burden it introduced.
Make luaPackages.compat53 install it's c-api files luv needs in order to build cleanly.
Tested Neovim builds and runs.

ccing people involved in #79870 :

@manveru, @rvolosatovs and @Ma27 (Neovim maintainers)
@teto
@bjornfor
@ArdaXi
@mjlbach
@jokogr
@chkno

Use github source tarball and use cmakeFlags instead of hacky sed to CMakeLists.txt. Mark TODO for darwin checks I can't perform myself.

jokogr

LGTM, thanks for the effort!

It works as expected in a Linux environment.

rnhmjoj · 2020-02-19T17:09:19Z

@GrahamcOfBorg build neovim

rnhmjoj

The darwin build is broken: libluv.dylib not found.

doronbehar · 2020-02-21T09:29:58Z

Note: Although #79870 was closed by @bjornfor , I doubt that it builds on Darwin as expected. nix-build -A luajit.pkgs.luv.libluv still fails for me on latest master:

these derivations will be built:
  /nix/store/9snxwz16ahc0rbdw4xkwhncgs3cgxv4a-luajit-2.1.0-beta3-luv-1.34.1-1.drv
building '/nix/store/9snxwz16ahc0rbdw4xkwhncgs3cgxv4a-luajit-2.1.0-beta3-luv-1.34.1-1.drv'...
unpacking sources
unpacking source archive /nix/store/f0az73f8fi7fp7cz55iapzwr0wh1kd93-luv-1.34.1-1.src.rock

Done. You may now enter directory
luv-1.34.1-1/luv-1.34.1-1
and type 'luarocks make' to build.
source root is ./luv-1.34.1-1/luv-1.34.1-1
setting SOURCE_DATE_EPOCH to timestamp 1579323846 of file ./luv-1.34.1-1/luv-1.34.1-1/src/work.c
patching sources
configuring
building
patching script interpreter paths in .
./deps/lua-compat-5.3/tests/test.lua: interpreter directive changed from "/usr/bin/env lua" to "/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/bin/lua"
installing

luv 1.34.1-1 depends on lua >= 5.1 (5.1-1 provided by VM)
Warning: unmatched variable LUA_LIBDIR
-- The C compiler identification is GNU 9.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /nix/store/1kn7fi3hhi33jms3113riyzwyn2yqpqd-gcc-wrapper-9.2.0/bin/gcc
-- Check for working C compiler: /nix/store/1kn7fi3hhi33jms3113riyzwyn2yqpqd-gcc-wrapper-9.2.0/bin/gcc
-- Check for working C compiler: /nix/store/1kn7fi3hhi33jms3113riyzwyn2yqpqd-gcc-wrapper-9.2.0/bin/gcc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Found LIBUV: /nix/store/w89ndqsb7ig22mw5hk7k7zfvxmhx44xb-libuv-1.34.2/lib/libuv.so
-- Lua: using information from luarocks
-- LUA_LIBDIR:
-- LUA_INCDIR: /nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/include/luajit-2.1
-- LUA: /nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/bin/luajit
-- Lua library: LUA_LIBRARIES-NOTFOUND
-- Configuring done
-- Generating done
-- Build files have been written to: /build/luv-1.34.1-1/luv-1.34.1-1/build.luarocks
Scanning dependencies of target luv
[ 50%] Building C object CMakeFiles/luv.dir/src/luv.c.o
[100%] Linking C shared library libluv.so
[100%] Built target luv
[100%] Built target luv
Install the project...
-- Install configuration: ""
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/luv-1.34.1-1-rocks/luv/1.34.1-1/lib/libluv.so.1.34.1
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/luv-1.34.1-1-rocks/luv/1.34.1-1/lib/libluv.so.1
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/luv-1.34.1-1-rocks/luv/1.34.1-1/lib/libluv.so
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/luv-1.34.1-1-rocks/luv/1.34.1-1/lib/pkgconfig/libluv.pc
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/include/luv/luv.h
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/include/luv/util.h
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/include/luv/lhandle.h
-- Installing: /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/include/luv/lreq.h
cp: cannot stat '/nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/luv-1.34.1-1-rocks/luv/1.34.1-1/lib/libluv.so': No such file or directory

Error: Failed copying /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/luv-1.34.1-1-rocks/luv/1.34.1-1/lib/libluv.so to /nix/store/f0a65c2fw8l24yb7y21h0bizzlq4iww7-luajit-2.1.0-beta3-luv-1.34.1-1/lib/lua/5.1/libluv.so
builder for '/nix/store/9snxwz16ahc0rbdw4xkwhncgs3cgxv4a-luajit-2.1.0-beta3-luv-1.34.1-1.drv' failed with exit code 1
error: build of '/nix/store/9snxwz16ahc0rbdw4xkwhncgs3cgxv4a-luajit-2.1.0-beta3-luv-1.34.1-1.drv' failed

Just as before. Hence I think this PR is still relevant. It's just that I can't fiddle around with the darwin specific build changes we need to set in order for Neovim to build on Darwin. Help will be appreciated.

rvolosatovs · 2020-02-21T10:37:54Z

This PR fixed the build for me on NixOS using latest nixos-unstable. I ran into #79870

pkgs/development/lua-modules/overrides.nix

nixos-discourse · 2020-02-22T17:30:48Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/why-does-gconf-depends-on-python2/5995/5

use neovim from stable channel until NixOS/nixpkgs#80528 is merged

pkgs/applications/editors/neovim/default.nix

pkgs/development/lua-modules/overrides.nix

doronbehar · 2020-02-23T11:37:58Z

@thefloweringash Thanks a lot for your help!

Everything should be ready now for a Darwin build test by @GrahamcOfBorg .

teto · 2020-02-24T15:04:46Z

Just to sum up the bigpicture issues:

luv either installs the module or the include directory but not both (which in my tests seem to be problematic here). Would be nice to have someone send a PR upstream (like a new target rather than have all checks depend on BUILD_MODULE).
the lua infrastructure doesn't play well with cmake build based packages. It seemed possible to pass flags to cmake via luarocks but in the end it isn't thus I've opened cmake build system doesnt take variables from LUAROCKS_CONFIG luarocks/luarocks#1160

Previously we had a luv lua module that contained an alternative luv built via cmake, here we just have a luv.

teto · 2020-02-24T15:05:06Z

@GrahamcOfBorg build neovim

Remove luv from lua-packages.csv

teto · 2020-02-26T00:04:44Z

pkgs/top-level/lua-packages.nix

@@ -99,6 +99,51 @@ with self; {

  luarocks-nix = callPackage ../development/tools/misc/luarocks/luarocks-nix.nix { };

+  luv = pkgs.stdenv.mkDerivation rec {


this doesn't appear as a lua module anymore, thus installation of luaPackages.nvim-client fails. You can add toLuaModule() but it triggers another issue. Also it doesn't seem to install lua files anymore does it ?

btw I've created this luvit/luv#457

do you need luarocks 3.3.1 ? I've reverted the luarocks bump in my fork, maybe we could do likewise until we find a better fix like the one mentioned in my luv issue.

👍 for catching that @teto (neovim builds fine because doCheck = false by default). After a while trying to debug this - I've finally realized that the BUILD_MODULE cmake flag is what's so problematic - they either install it as a module without headers (which is good only for native Lua packages) or they install everything (which is suitable for neovim). This very issue is what created the original motivation for the libluv and luv different derivations ! I've failed to understand that earlier..

Let's wait for their response for my luvit/luv#458 (comment) .

To be fair, there is also the problem that the current nixpkgs lua infrastructure doesn't work with cmake based project, I've worked quite a bit on it yesterday and found some issues with luarocks . I think I could solve it via creating a cmake wrapper but meanwhile I've proceeded to upload some unrelated changes I had in my fork #81067 . I don't have the space to run a nixpkgs-review on it (trying to buy a new SSD) but it should be ok overall.

luv should make sure that SHAREDLIBS_INSTALL_INC_DIR is not empty, it should be possible to define it with the existing variables.

Agree. I'm working on a fix for luv's CMakeLists right now, feel free to open an issue first there and explain the issue.

@teto while investigating the issue with luv's CMakeLists, I've come to the conclusion that luarocks make sets too many cmake variables, and I don't think we can stop it from doing it. Here's the list of them extracted out of a nix-build -A luajit.pkgs.luv while NIX_DEBUG = 2; was set in luv's derivation:

-G"Unix Makefiles" -DCMAKE_MODULE_LINKER_FLAGS="-shared" -DLIBDIR="/nix/store/5wf8zrgpp199pmbbgyvkp7hc484pzrbs-luajit-2.1.0-beta3-luv-1.34.2-0/luv-1.34.2-0-rocks/luv/1.34.2-0/lib" -DLUA_INCDIR="/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/include/luajit-2.1" -DLUA_LIBDIR="" -DLUA="/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/bin/luajit" -DCMAKE_LIBRARY_PATH="/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/lib:/nix/store/w89ndqsb7ig22mw5hk7k7zfvxmhx44xb-libuv-1.34.2/lib:/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/lib:/nix/store/w89ndqsb7ig22mw5hk7k7zfvxmhx44xb-libuv-1.34.2/lib" -DCMAKE_INCLUDE_PATH="/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/include:/nix/store/w89ndqsb7ig22mw5hk7k7zfvxmhx44xb-libuv-1.34.2/include:/nix/store/1m8vh1byjnjmjkpdidcqc37cykgsqjap-luajit-2.1.0-beta3/include:/nix/store/w89ndqsb7ig22mw5hk7k7zfvxmhx44xb-libuv-1.34.2/include" -DLUADIR="/nix/store/5wf8zrgpp199pmbbgyvkp7hc484pzrbs-luajit-2.1.0-beta3-luv-1.34.2-0/luv-1.34"

There are a couple of troubles with this:

LIBDIR is set to some distant path inside $out and not just $out/lib.

LUA_LIBDIR is empty.

In my opinion, (1) is severe and unfixable - it's hard-coded inside luarocks make. I think luarocks make can't even imagine itself running a cmake command that will imply installing files in a $prefix/lib instead of $prefix/${rockname-version}-rocks/${rockname}/${version}/lib. Even if we'll fix the original issue cp error this PR was written for, I doubt that neovim will be able to find pkg-config files for luv inside the standard ${luv}/lib path.

I'm not sure what's the effects of (2) but I don't like it either.

This is very messy indeed, most likely because luarocks doesn't expect packages that provide headers and shared libraries someone (or a project like neovim) would expect to find in the standard locations. And I think I realize now that according to this behavior, the original design of luv's CMakeLists files chose to make the BUILD_MODULE and BUILD_SHARED_LIBS colliding.

While writing this, I think perhaps we should provide a libluv package in lua-packages.nix that will use stdenv.mkDerivation and that will be used by neovim along with another luv package that we'll only override, just as before.

I've tried my idea and I think it's the most elegant solution to the issue. Especially considering luarocks lack of support for installing arbitrary files to a $prefix, as explained above. I've pushed the final fix for this.

having to maintain the same package twice because its build system cant find where to install files does not seem elegant + it will keep being a headache; better fix it now that we have everything in mind. As for the cmake call via luarocks; it s not a problem; you can override the parameters via environment variables or patch the luv rockspec. We better open an issue on luv. I am busy tomorrow but will try to do at least saturday.

Fixes luvit#457 and fixes NixOS/nixpkgs#80528

amckinlay · 2020-05-24T07:35:37Z

HI, I just tried to install neovim with nix-darwin and I am getting the same build error:

...
[100%] Building C object src/nvim/CMakeFiles/nvim.dir/xdiff/xprepare.c.o
make[2]: *** No rule to make target '/nix/store/nyf0qhx47vad558rcv8bskfkdvs9wwav-luajit-2.1.0-beta3-luv-1.34.1-1/lib/lua/5.1/libluv.dylib', needed by 'bin/nvim'.  Stop.
make[2]: *** Waiting for unfinished jobs....
[100%] Building C object src/nvim/CMakeFiles/nvim.dir/xdiff/xutils.c.o
make[1]: *** [CMakeFiles/Makefile2:5012: src/nvim/CMakeFiles/nvim.dir/all] Error 2
make: *** [Makefile:152: all] Error 2
builder for '/nix/store/bpxyw4r1h2wklcwc6kiisq2n9cps67k9-neovim-unwrapped-0.4.3.drv' failed with exit code 2
cannot build derivation '/nix/store/84wks6big9cg91xw8pym4j6kbig22i5s-neovim-0.4.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/84wks6big9cg91xw8pym4j6kbig22i5s-neovim-0.4.3.drv' failed

As neovim is one of the first packages a user might install after installing nix, shouldn't this be fixed ASAP?

LnL7 · 2020-05-24T08:38:16Z

That has been fixed quite some time ago by the reverts.

doronbehar · 2020-05-24T22:15:45Z

That has been fixed quite some time ago by the reverts.

This is evidence that a Darwin user is still encountering this issue, which is troubling but I have no idea why is that.

@amckinlay I'm sorry to hear about your experience, but unfortunately this issue is a nasty one which I think most of the involved consider it "upstream's fault". The discussions and comments above should explain it more thoroughly, but basically, we are stuck because of: luarocks/luarocks#509 and/or luarocks/luarocks#339 . Note that we are also stuck with Luarocks 3.2.1 because updating it will break Neovim for all of us. See luarocks/luarocks#1155 .

Even if we'd try to solve this without waiting for upstream, a cleaner fix (then this PR) is orthogonal to some other big changes to Nixpkgs:

And more... 😞

LnL7 · 2020-05-25T07:22:30Z

This is evidence that a Darwin user is still encountering this issue, which is troubling but I have no idea why is that.

@doronbehar No my revert was for the darwin side. https://hydra.nixos.org/job/nixpkgs/trunk/neovim.x86_64-darwin
As I mentioned in the pr, currently we can't update luv or luarocks, updating either will break one of the platforms.

@amckinlay I would suggest ask a question on irc or discourse, I suspect you've not updated your channel (eg. multi-user) but this is not the right place for debugging that.

amckinlay · 2020-05-25T21:33:27Z

@LnL7 @doronbehar Okay, it was fixed. For some reason all my channels were missing so my sudo nix-channel --updates haven't been doing anything for a while. :(

stale · 2021-06-07T13:57:34Z

I marked this as stale due to inactivity. → More info

SuperSandro2000 · 2021-10-16T16:36:03Z

pkgs/top-level/lua-packages.nix

+      rev = version;
+      sha256 = "0iq272n7p0wkll4a7d880qyhdp65582cwc3b2zzrirpli93x3v87";
+    };
+    disabled = (luaOlder "5.1");


Suggested change

disabled = (luaOlder "5.1");

disabled = luaOlder "5.1";

SuperSandro2000 · 2021-10-16T16:36:11Z

pkgs/top-level/lua-packages.nix

+    # So we can be sure no internal dependency is used from the repo and that
+    # everything is provided by us
+    postUnpack = ''
+     rm -rf deps


Suggested change

rm -rf deps

rm -r deps

SuperSandro2000 · 2021-10-16T16:36:33Z

pkgs/top-level/lua-packages.nix

+    NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin
+      (if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");


Suggested change

NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin

(if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");

NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin (if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");

SuperSandro2000 · 2021-10-16T16:36:54Z

pkgs/top-level/lua-packages.nix

+      (if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");
+    propagatedBuildInputs = [ lua ];
+
+    meta = with stdenv.lib; {


Suggested change

meta = with stdenv.lib; {

meta = with lib; {

SuperSandro2000 · 2021-10-16T16:37:16Z

pkgs/top-level/lua-packages.nix

+      license = {
+        fullName = "Apache 2.0";
+      };


Suggested change

license = {

fullName = "Apache 2.0";

};

license = licenses.asl20;

SuperSandro2000 · 2021-10-16T16:37:29Z

pkgs/development/lua-modules/overrides.nix

+    NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin
+      (if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");


Suggested change

NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin

(if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");

NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin (if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");

SuperSandro2000 · 2021-10-16T16:37:56Z

pkgs/development/lua-modules/overrides.nix

+      rm -rf deps
+    ''
+    # See the following issues:
+    # - https://github.com/luarocks/luarocks/issues/1160
+    # - https://github.com/luarocks/luarocks/issues/509
+    # - https://github.com/luarocks/luarocks/issues/339
+    + ''
+      sed -i 's,\(option(WITH_SHARED_LIBUV.*\)OFF,\1ON,' CMakeLists.txt


Suggested change

rm -rf deps

''

# See the following issues:

# - https://github.com/luarocks/luarocks/issues/1160

# - https://github.com/luarocks/luarocks/issues/509

# - https://github.com/luarocks/luarocks/issues/339

+ ''

sed -i 's,$option(WITH_SHARED_LIBUV.*$OFF,\1ON,' CMakeLists.txt

rm -r deps

# See the following issues:

# - https://github.com/luarocks/luarocks/issues/1160

# - https://github.com/luarocks/luarocks/issues/509

# - https://github.com/luarocks/luarocks/issues/339

sed -i 's,$option(WITH_SHARED_LIBUV.*$OFF,\1ON,' CMakeLists.txt

This reverts commit eec90bc. See discussion in: NixOS#141718 NixOS#80528

doronbehar added 2 commits February 19, 2020 13:48

luaPackages.luv: Clean up build

33ea31e

Use github source tarball and use cmakeFlags instead of hacky sed to CMakeLists.txt. Mark TODO for darwin checks I can't perform myself.

luaPackages.compat53: copy c-api/ needed for luv build

a60662e

doronbehar changed the title ~~luaPackages.luv cleanup build~~ luaPackages.luv: cleanup build Feb 19, 2020

ofborg bot added the 6.topic: lua label Feb 19, 2020

ofborg bot requested review from Ma27 and manveru February 19, 2020 12:13

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Feb 19, 2020

jokogr approved these changes Feb 19, 2020

View reviewed changes

rnhmjoj requested changes Feb 19, 2020

View reviewed changes

doronbehar mentioned this pull request Feb 21, 2020

Neovim (luajitPackages.luv) does not install correctly #80704

Closed

vcunat reviewed Feb 21, 2020

View reviewed changes

pkgs/development/lua-modules/overrides.nix Outdated Show resolved Hide resolved

evanjs added a commit to evanjs/nixos_cfg that referenced this pull request Feb 23, 2020

vim: pin neovim to stable channel

b817650

use neovim from stable channel until NixOS/nixpkgs#80528 is merged

thefloweringash reviewed Feb 23, 2020

View reviewed changes

pkgs/applications/editors/neovim/default.nix Outdated Show resolved Hide resolved

pkgs/development/lua-modules/overrides.nix Outdated Show resolved Hide resolved

pkgs/development/lua-modules/overrides.nix Outdated Show resolved Hide resolved

doronbehar added 3 commits February 23, 2020 13:32

luaPackages.luv: Remove # TODO for darwin linking

139c3cd

luaPackages.luv: Remove install names darwin hook

3025302

neovim: Remove no longer needed luv darwin hook

6a16042

luaPackages.luv: Use lua-packages.nix instead of lua overrides.nix

f1f3d05

Remove luv from lua-packages.csv

ofborg bot added the 8.has: clean-up label Feb 25, 2020

ofborg bot requested a review from vcunat February 25, 2020 07:12

Ma27 approved these changes Feb 25, 2020

View reviewed changes

teto mentioned this pull request Feb 25, 2020

allow to run luarocks test #81067

Merged

10 tasks

teto requested changes Feb 26, 2020

View reviewed changes

Timothy- pushed a commit to luvitred/luv that referenced this pull request Apr 17, 2020

CMake: Make BUILD_MODULE and BUILD_SHARED_LIBS non inclusive

da307e6

Fixes luvit#457 and fixes NixOS/nixpkgs#80528

doronbehar mentioned this pull request May 29, 2020

mpv: don't use generated luasocket #89145

Closed

10 tasks

lblasc mentioned this pull request Jun 6, 2020

lyaml: init at 6.2.5-1, update almost all luarocks generated packages #89632

Merged

10 tasks

doronbehar mentioned this pull request Aug 14, 2020

neovim: fix build on Darwin #95364

Merged

10 tasks

ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021

teto mentioned this pull request Oct 16, 2021

luarocks: 3.2.1 -> 3.7.0 #141718

Merged

7 tasks

SuperSandro2000 reviewed Oct 16, 2021

View reviewed changes

stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Oct 16, 2021

SuperSandro2000 reviewed Oct 16, 2021

View reviewed changes

7c6f434c added a commit to 7c6f434c/nixpkgs that referenced this pull request Oct 16, 2021

Revert "luarocks: 3.2.1 -> 3.7.0"

5c93a77

This reverts commit eec90bc. See discussion in: NixOS#141718 NixOS#80528

7c6f434c mentioned this pull request Oct 16, 2021

Luarocks use 3.2.1 #141899

Merged

12 tasks

jordanisaacs pushed a commit to jordanisaacs/nixpkgs that referenced this pull request Oct 26, 2021

Revert "luarocks: 3.2.1 -> 3.7.0"

169c821

This reverts commit eec90bc. See discussion in: NixOS#141718 NixOS#80528

teto closed this in teto/luv@0494414 Mar 25, 2022

teto mentioned this pull request Mar 29, 2022

luarocks-nix: bump #166162

Merged

13 tasks

doronbehar deleted the improve-neovim branch March 2, 2023 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

luaPackages.luv: cleanup build #80528

luaPackages.luv: cleanup build #80528

doronbehar commented Feb 19, 2020 •

edited

Loading

jokogr left a comment

rnhmjoj commented Feb 19, 2020

rnhmjoj left a comment

doronbehar commented Feb 21, 2020

rvolosatovs commented Feb 21, 2020

nixos-discourse commented Feb 22, 2020

doronbehar commented Feb 23, 2020

teto commented Feb 24, 2020

teto commented Feb 24, 2020

teto Feb 26, 2020

teto Feb 26, 2020

teto Feb 26, 2020

doronbehar Feb 26, 2020

teto Feb 26, 2020

teto Feb 27, 2020

doronbehar Feb 27, 2020

doronbehar Feb 27, 2020 •

edited

Loading

doronbehar Feb 27, 2020

teto Feb 28, 2020

amckinlay commented May 24, 2020

LnL7 commented May 24, 2020

doronbehar commented May 24, 2020 •

edited

Loading

LnL7 commented May 25, 2020

amckinlay commented May 25, 2020

stale bot commented Jun 7, 2021

SuperSandro2000 Oct 16, 2021

SuperSandro2000 Oct 16, 2021

SuperSandro2000 Oct 16, 2021

SuperSandro2000 Oct 16, 2021

SuperSandro2000 Oct 16, 2021

SuperSandro2000 Oct 16, 2021

SuperSandro2000 Oct 16, 2021

		@@ -99,6 +99,51 @@ with self; {

		luarocks-nix = callPackage ../development/tools/misc/luarocks/luarocks-nix.nix { };

		luv = pkgs.stdenv.mkDerivation rec {

		NIX_LDFLAGS = pkgs.lib.optionalString pkgs.stdenv.isDarwin
		(if isLuaJIT then "-lluajit-${lua.luaversion}" else "-llua");

luaPackages.luv: cleanup build #80528

luaPackages.luv: cleanup build #80528

Conversation

doronbehar commented Feb 19, 2020 • edited Loading

Motivation for this change

Things done

jokogr left a comment

Choose a reason for hiding this comment

rnhmjoj commented Feb 19, 2020

rnhmjoj left a comment

Choose a reason for hiding this comment

doronbehar commented Feb 21, 2020

rvolosatovs commented Feb 21, 2020

nixos-discourse commented Feb 22, 2020

doronbehar commented Feb 23, 2020

teto commented Feb 24, 2020

teto commented Feb 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doronbehar Feb 27, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amckinlay commented May 24, 2020

LnL7 commented May 24, 2020

doronbehar commented May 24, 2020 • edited Loading

LnL7 commented May 25, 2020

amckinlay commented May 25, 2020

stale bot commented Jun 7, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doronbehar commented Feb 19, 2020 •

edited

Loading

doronbehar Feb 27, 2020 •

edited

Loading

doronbehar commented May 24, 2020 •

edited

Loading