-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lyaml: init at 6.2.5-1, update almost all luarocks generated packages #89632
Conversation
could you not update the lua packages version ? (but just change the url so that it uses mirrors instead). I am afraid this would break other things. |
@teto I've checked this pull request with: In my opinion this is safe to merge. |
@GrahamcOfBorg build neovim luaPackages.lyaml luaPackages.cqueues |
builds look ok but at runtime there may be issues. I will merge anyway.
I will try to update the lua documentation #55302 this WE. |
I don't care if my pulseaudio will move from one place to another, as long as I'm pinged to test something that's supposed to work. @teto I think the issue I wrote about here is orthogonal to #89145 (comment) - |
This reverts commit 47ad7d3. The fix isn't needed after the update contained in PR NixOS#89632.
The |
@doronbehar sry I forgot about that. Luarocks |
My |
Sigh.... I really don't know what to do, it's working when I build it with a makefile, and when I use |
@teto could it be something with the Makefile? https://github.com/doronbehar/lua-pulseaudio/blob/v0.2/Makefile |
From some reason, the package is not usable if it's built with `buildLuarocksPackage`. Adding `extraVariables` as in `makeFlags` doesn't work. See: NixOS#89632 (comment) Also, remove it from luarocks-packages.csv so hopefully no one will touch it in the future.
what I meant is that in so the extra args in the makefile could be passed to luarocks via an override so you dont need a manual one a priori. |
@teto please do this:
diff --git i/pkgs/development/lua-modules/overrides.nix w/pkgs/development/lua-modules/overrides.nix
index 30be2c197a5..c88d375d5be 100644
--- i/pkgs/development/lua-modules/overrides.nix
+++ w/pkgs/development/lua-modules/overrides.nix
@@ -324,5 +324,10 @@ with super;
nativeBuildInputs = [
pkgs.pulseaudio pkgs.pkgconfig
];
+ extraVariables = {
+ INST_LIBDIR = "${placeholder "out"}/lib/lua/${lua.luaversion}";
+ INST_LUADIR = "${placeholder "out"}/share/lua/${lua.luaversion}";
+ LUA_BINDIR = "${placeholder "out"}/bin";
+ };
});
}
ldd $(nix-build -A luajitPackages.pulseaudio)/lib/lua/5.1/pulseaudio.so
ldd $(nix-build -A luajitPackages.pulseaudio)/lib/lua/5.1/pulseaudio.so And you should be able to see that |
cool that you tried ! sry if I dont answer quickly I am pretty swamped at the moment. Maybe it would accept the extra varialbes if https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/lua-5/build-lua-package.nix#L228 was changed to |
I don't understand - I never heard of this env variable before - Now I notice, that also when I run |
The most interesting part is: https://gist.github.com/doronbehar/0fadaebd60bdf6ea0540f2b8990516de#file-luarocks-make-log-L45 - it's as if |
The warnings there remind me of luarocks/luarocks#1155 (comment) 😞 . |
Motivation for this change
Update luarocks generated packages and add lyaml - lua yaml parser. I've also found that lua pulseaduio package was missing from
generated-packages.nix
.I've tested most of the updated packages.
cc @teto @vcunat
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)