luarocks: 3.2.1 -> 3.7.0

[averms]

Motivation for this change

Update luarocks. The version currently packaged is broken for Lua version 5.4: luarocks/luarocks#1060

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• N/A For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• N/A Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • N/A (I think) (Package updates) Added a release notes entry if the change is major or breaking
  • N/A (Module updates) Added a release notes entry if the change is significant
  • N/A (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[mweinelt]

After this change libluv fails to build for me. This subsequently breaks neovim.

❯ nix-build -A luaPackages.luv.libluv
these derivations will be built:
  /nix/store/3l5z4zb5a9hl1jqpmp1m3z1qb4z17ylz-lua5.2-luv-1.42.0-0.drv
these paths will be fetched (0.13 MiB download, 0.72 MiB unpacked):
  /nix/store/ivnqhki0rmgq0lkl3kcfh69kj5gwnlvz-hook
  /nix/store/yi54jrhi7wd0xn1d5mjnc21f4sr0fkjz-luarocks-3.7.0
copying path '/nix/store/ivnqhki0rmgq0lkl3kcfh69kj5gwnlvz-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/yi54jrhi7wd0xn1d5mjnc21f4sr0fkjz-luarocks-3.7.0' from 'https://cache.nixos.org'...
building '/nix/store/3l5z4zb5a9hl1jqpmp1m3z1qb4z17ylz-lua5.2-luv-1.42.0-0.drv' on 'ssh://hexa@phoibe.cysec.de'...
copying path '/nix/store/irxad7zv4sz4wqq3ab8hr4xh6nbrcyfc-lua-5.2.4' from 'https://cache.nixos.org'...
copying path '/nix/store/ivnqhki0rmgq0lkl3kcfh69kj5gwnlvz-hook' from 'https://cache.nixos.org'...
copying path '/nix/store/yi54jrhi7wd0xn1d5mjnc21f4sr0fkjz-luarocks-3.7.0' from 'https://cache.nixos.org'...
unpacking sources
unpacking source archive /nix/store/7cdrspxmi38iv01p34shyagp31aywgj9-luv-1.42.0-0.tar.gz
source root is luv-1.42.0-0
setting SOURCE_DATE_EPOCH to timestamp 1632044224 of file luv-1.42.0-0/src/work.c
patching sources
configuring
building
installing

luv 1.42.0-0 depends on lua >= 5.1 (5.2-1 provided by VM)
Warning: unmatched variable LUA_LIBDIR
Warning: unmatched variable LUALIB
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- The C compiler identification is GNU 10.3.0
-- The ASM compiler identification is GNU
-- Found assembler: /nix/store/s5hkav7whndbfz0szshpb46h4idqdq9a-gcc-wrapper-10.3.0/bin/gcc
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /nix/store/s5hkav7whndbfz0szshpb46h4idqdq9a-gcc-wrapper-10.3.0/bin/gcc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Warning (dev) at /nix/store/m33sn6h5kgfbk3z4avwmgxam1dny07i0-cmake-3.21.2/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args` (LIBUV) does
  not match the name of the calling package (Libuv).  This can lead to
  problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/Modules/FindLibuv.cmake:33 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:68 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found LIBUV: /nix/store/bjdgyi0n6v6vyx67kjnhx08fj5b283v0-libuv-1.42.0/lib/libuv.so
-- Lua: using information from luarocks
-- LUA_LIBDIR:
-- LUA_LIBFILE:
-- LUA_INCDIR: /nix/store/irxad7zv4sz4wqq3ab8hr4xh6nbrcyfc-lua-5.2.4/include
-- LUA: /nix/store/irxad7zv4sz4wqq3ab8hr4xh6nbrcyfc-lua-5.2.4/bin/lua
-- Lua library not set, presuming LuaRocks config has link_lua_explicitly set to false
-- Configuring done
-- Generating done
-- Build files have been written to: /build/luv-1.42.0-0/build.luarocks
[ 50%] Building C object CMakeFiles/libluv.dir/src/luv.c.o
[100%] Linking C shared library libluv.so
[100%] Built target libluv
Consolidate compiler generated dependencies of target libluv
[100%] Built target libluv
Install the project...
-- Install configuration: ""
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/luv-1.42.0-0-rocks/luv/1.42.0-0/lib/libluv.so.1.42.0
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/luv-1.42.0-0-rocks/luv/1.42.0-0/lib/libluv.so.1
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/luv-1.42.0-0-rocks/luv/1.42.0-0/lib/libluv.so
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/luv-1.42.0-0-rocks/luv/1.42.0-0/lib/pkgconfig/libluv.pc
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/include/luv/luv.h
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/include/luv/util.h
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/include/luv/lhandle.h
-- Installing: /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/include/luv/lreq.h
cp: cannot stat '/nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/luv-1.42.0-0-rocks/luv/1.42.0-0/lib/libluv.so.1': No such file or directory

Error: Failed copying /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/luv-1.42.0-0-rocks/luv/1.42.0-0/lib/libluv.so.1 to /nix/store/yxy20g82251lnjjxlazrk06w1vjbys79-lua5.2-luv-1.42.0-0/lib/lua/5.2/libluv.so.1

[averms]

Yes that is a problem. It seems the shared object for libluv is not even being built.

[teto]

it's a known issue see #80528

[doronbehar]

@7c6f434c please revert this update 🙏 We can't break updates for all Neovim users..

[7c6f434c]

Let's at least add 3.7 as a separate package so that it is more visible that Luarocks is explicitly no the freshest

[teto]

I wanted to hack on neovim which required a newer libuv, so I spent a few hours on this issue and related (#163134) and found the luarocks bug luarocks/luarocks#1402 (marked as wont fix). I ended up doing things sideways: Could anyone check that #166162 works for them ?