gcc: backport cda41ce0 from gcc 11.1.0 if isPower64 && isMusl #170400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in libgcc which manifests when building static binaries using musl-libc was fixed in gcc 11.1.0, but the fix has not been backported to gcc 10. This commit cherry-picks the commit from upstream and applies it in the case (isPower64 && isMusl) where it matters: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cda41ce0e8414aec59e6b9fbe645d96e6e8193e2
ghost
mentioned this pull request
9 tasks
ofborg
bot
added
10.rebuild-darwin: 0
|
@ofborg build pkgsCross.powernv.pkgsStatic.nix_2_4 |
|
ofborg said:
|
ghost
mentioned this pull request
13 tasks
|
@ofborg eval |
ghost
mentioned this pull request
9 tasks
|
@ofborg eval |
1 similar comment
|
@ofborg eval |
|
This patch is in gcc 10.4.0, so we no longer need it after 3f88d51 |
ghost
closed this
ghost
deleted the
gcc-backport-cda41ce0-from-gcc-11-1-if-isPower64-and-isMusl
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A bug in libgcc, which manifests when building static binaries using musl-libc, was fixed in gcc 11.1.0. The fix has not been backported to gcc 10. This commit cherry-picks the commit from upstream and applies it in the case
(isPower64 && isMusl)where it matters:https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cda41ce0e8414aec59e6b9fbe645d96e6e8193e2
The big payoff here is that this now works:
... that, plus the bootstrap-files (#168199, merged) mean that people can now try out nixpkgs on powerpc64le without having to figure out which bazillion different packages from their host distribution are needed in order for nix to compile. They can just grab a statically-linked nix binary (maybe Hydra could build this?) and bootstrap using that.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)