Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dirsearch: init at 0.4.3 #191097

Closed
wants to merge 1 commit into from

Conversation

MrMebelMan
Copy link
Contributor

Description of changes

Add a new package

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@MrMebelMan
Copy link
Contributor Author

I've managed to build and run it, but there are certain issues:

  1. When the program is running, it outputs a warning:
    RequestsDependencyWarning: urllib3 (1.26.11) or chardet (5.0.0) doesn't match a supported version!
  2. Tests are disabled because they throw an error:
    TypeError: DynamicContentParser.__init__() missing 4 required positional arguments: 'requester', 'path', 'firstPage', and 'secondPage'
  3. Install phase was overridden because of "[....]/nix-support/setup-hook: line 13: pushd: dist: No such file or directory" error.

@senges
Copy link

senges commented Oct 13, 2022

dirsearch 0.4.3 has just been released 8 days ago, maybe the new version could be included in this PR ?

Can't wait to have dirsearch on Nix ! What's missing to merge ?

@MrMebelMan MrMebelMan changed the title python3Packages.dirsearch: init at 0.4.2 python3Packages.dirsearch: init at 0.4.3 Oct 17, 2022
@MrMebelMan
Copy link
Contributor Author

@senges, thanks for the info! I've updated the PR to v0.4.3. It fixed some issues, now the only problem is that I'm not able to run the tests. I've tested the package manually though, it appears to work just fine.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
quantenzitrone added a commit to quantenzitrone/nixpkgs that referenced this pull request Oct 22, 2024
quantenzitrone added a commit to quantenzitrone/nixpkgs that referenced this pull request Oct 25, 2024
@Scrumplex Scrumplex closed this in 2367be9 Dec 5, 2024
prinzdezibel pushed a commit to prinzdezibel/nixpkgs that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants