-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.dirsearch: init at 0.4.3 #350550
Conversation
|
1f6329d
to
ba49de0
Compare
ba49de0
to
2367be9
Compare
@ofborg build python312Packages.dirsearch |
buildPythonPackage rec { | ||
pname = "dirsearch"; | ||
version = "0.4.3"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please set pyproject = true
and build-system = [ setuptools ]
to avoid legacy build.
pyproject: Whether the pyproject format should be used. As all other formats are deprecated, you are recommended to set this to true. When you do so, pypaBuildHook will be used, and you can add the required build dependencies from build-system.requires to build-system. Note that the pyproject format falls back to using setuptools, so you can use pyproject = true even if the package only has a setup.py. When set to false, you can use the existing hooks or provide your own logic to build the package. This can be useful for packages that don't support the pyproject format. When unset, the legacy setuptools hooks are used for backwards compatibility.
cp $src/{dirsearch,__init__}.py $dirsearchpath/dirsearch | ||
cp -r $src/db $dirsearchpath/dirsearch | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please enable tests using pythonImportsCheck
and pytestCheckHook
.
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#testing-python-packages-testing-python-packages
|
||
meta = { | ||
changelog = "https://github.com/maurosoria/dirsearch/releases/tag/${version}"; | ||
description = "command-line tool for brute-forcing directories and files in webservers, AKA a web path scanner"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description = "command-line tool for brute-forcing directories and files in webservers, AKA a web path scanner"; | |
description = "Command-line tool for brute-forcing directories and files in webservers, AKA a web path scanner"; |
closes #191097
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.