Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.dirsearch: init at 0.4.3 #350550

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

quantenzitrone
Copy link
Contributor

@quantenzitrone quantenzitrone commented Oct 22, 2024

closes #191097

Things done

  • Built on platform(s)
    • x86_64-linux
      • python 3.13, 3.11 and 3.10
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium October 22, 2024 21:52
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 22, 2024
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350550


x86_64-linux

✅ 4 packages built:
  • python311Packages.dirsearch
  • python311Packages.dirsearch.dist
  • python312Packages.dirsearch
  • python312Packages.dirsearch.dist

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 26, 2024
@FliegendeWurst
Copy link
Member

@ofborg build python312Packages.dirsearch

@Scrumplex Scrumplex merged commit 7a8bfb7 into NixOS:master Dec 5, 2024
28 of 29 checks passed
buildPythonPackage rec {
pname = "dirsearch";
version = "0.4.3";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set pyproject = true and build-system = [ setuptools ] to avoid legacy build.

pyproject: Whether the pyproject format should be used. As all other formats are deprecated, you are recommended to set this to true. When you do so, pypaBuildHook will be used, and you can add the required build dependencies from build-system.requires to build-system. Note that the pyproject format falls back to using setuptools, so you can use pyproject = true even if the package only has a setup.py. When set to false, you can use the existing hooks or provide your own logic to build the package. This can be useful for packages that don't support the pyproject format. When unset, the legacy setuptools hooks are used for backwards compatibility.

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#buildpythonpackage-parameters-buildpythonpackage-parameters

cp $src/{dirsearch,__init__}.py $dirsearchpath/dirsearch
cp -r $src/db $dirsearchpath/dirsearch
'';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


meta = {
changelog = "https://github.com/maurosoria/dirsearch/releases/tag/${version}";
description = "command-line tool for brute-forcing directories and files in webservers, AKA a web path scanner";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "command-line tool for brute-forcing directories and files in webservers, AKA a web path scanner";
description = "Command-line tool for brute-forcing directories and files in webservers, AKA a web path scanner";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants