-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/tests: add ROCm and amdvlk tests #200757
Conversation
I've been very sick for a bit now so I can't divert much energy to testing this ATM, but on the surface it looks fine. |
Also, |
Thanks a lot for your comments! Good point about hydra, I was not sure if it will run all tests by default. It’s still using a derivation to run the actual test, so that it’s mostly isolated. @Madouura, I changed the Diff compared to the previous version. |
Putting the tests under the packages is a good idea to keep I added |
Add a function to create tests that use hardware from the host system like GPUs.
Rebased and set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the tests, LGTM.
Description of changes
Testing ROCm and other software like amdvlk is slightly more difficult, because it needs hardware like GPUs to run on.
This PR adds some infrastructure –
make-test-hardware.nix
analogous tomake-test-python.nix
– that makes it easy to write such tests and run them by giving access to the host hardware into the nix build sandbox.The tests added here are very basic and are meant more for demonstration of how it works (and smoke testing that nothing fundamental is broken).
The added tests can be run with
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes