-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zeal: unstable-2021-12-25 → unstable-2022-10-02 #202103
Conversation
a92c2b0
to
d99d679
Compare
Why the move to qt6? I'm not saying not to do it, but what is the reason? |
In general because, Upstream added qt6 support on July ( zealdocs/zeal#1420 ) Personally because qt 6.4.1 compiled out of the box with gcc12 and qt 5.15.7 didn't (checked, still the latest lgpl patch release) |
The issue with qt6 is that the applications look like crap under KDE because the theme isn't picked up automatically. I'm much more in favour of doing something like this instead: {
zeal-qt5 = libsForQt5.callPac......;
zeal-qt6 = qt6Packages.callPac......;
zeal = zeal-qt5;
} At least people have a choice between TheNewHotness and Doesn'tLookLikeTheRedHeadedStepChild. At least as long as upstream supports both. A different example is something like Calibre that has moved to Qt6 dropping Qt5 support where we obviously don't have a choice. |
Oh, I wasn't aware of that issue. Will amend the merge request like that. |
d99d679
to
df450cf
Compare
Only tested zeal-qt6 on GNOME 43, could you test zeal-qt5? |
Have a look at #202131 for how to deal with the differences between qt5 and qt6. |
Oh right
That is very useful. |
df450cf
to
aff0d0c
Compare
aff0d0c
to
b872cd9
Compare
Change of note: qt5 → qt6
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes