-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qownnotes: build with Qt6 #227301
qownnotes: build with Qt6 #227301
Conversation
You can drop qtxmlpatterns altogether, I removed the need for that dependency when porting the app to Qt6. |
e449379
to
fa94b1d
Compare
Rebased onto master after version update got merged. |
Why do we need both options? If qt6 just works, we can only offer that. |
Yeah, I was asking the same in #227301 (comment). |
I saw this merged PR and the comment by @peterhoeg and thought that Qt6 might not be usable for some, so I wanted to be on the safe side like they did with If there is no advantage in keeping both, then I will happily adapt the PR to only use Qt6. |
And 32bit isn't supported by Qt6 any more...
Yes, I feared as much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qownnotes-qt6 builds and works nice. I coudn't find any issues.
Needs rebase at least. |
5d66b7b
to
dbfdf61
Compare
Since the consensus seems to be that there is no real problem in moving to building with Qt6, I changed the PR to only build with Qt6. On NixOS with KDE Plasma QOwnNotes built with Qt6 looks just fine. I've also successfully built it on x86_64-darwin, and the only issue I've seen, is that the title bar is not adapting to my dark system theme, but I guess that's manageable. |
dbfdf61
to
57de621
Compare
Not relevant to this PR, but I'm getting a bunch of warnings like this for these two plugins.
@pbek are you aware of this? |
Result of 1 package built:
|
Result of 1 package built:
|
Result of 1 package built:
|
This is not specific to |
Thank you! |
I got similar (but different) warnings:
|
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)