Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python310Packages.apache-beam: add compatibility with httplib2 0.21.0 #205029

Merged
merged 1 commit into from
Dec 11, 2022
Merged

python310Packages.apache-beam: add compatibility with httplib2 0.21.0 #205029

merged 1 commit into from
Dec 11, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Dec 7, 2022 •
edited
Loading

Description of changes

Pulls in apache/beam#24573, which is needed after #200903.

Fixes #205574.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested review from FRidh and jonringer as code owners December 7, 2022 19:49
@ofborg ofborg bot requested a review from ndl December 7, 2022 20:01
fabaff
fabaff approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit a6459aa into NixOS:master Dec 11, 2022
@tjni tjni deleted the beam branch December 11, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@ndl ndl Awaiting requested review from ndl

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python39Packages.apache-beam build failure on x86_64-linux as of cb7e9fc3
2 participants
@tjni @fabaff