Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump httplib2 upper bound to 0.22.0. #24573

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Dec 7, 2022

Version 0.21.0 was released on October 29th, 2022. Its CHANGELOG only mentions one notable change:

http: `Content-Encoding: deflate` must accept zlib encapsulation

which is httplib2/httplib2#230. This does not look like it should affect anything.

Closes #19929. Well, that issue was created a long time ago but we can repurpose it and close it automatically. It popped up when I searched for this in the issue tracker.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #24573 (37358ff) into master (37358ff) will not change coverage.
The diff coverage is n/a.

❗ Current head 37358ff differs from pull request most recent head e333c67. Consider uploading reports for the commit e333c67 to get more accurate results

@@           Coverage Diff           @@
##           master   #24573   +/-   ##
=======================================
  Coverage   73.12%   73.12%           
=======================================
  Files         731      731           
  Lines       97960    97960           
=======================================
  Hits        71638    71638           
  Misses      24966    24966           
  Partials     1356     1356           
Flag Coverage Δ
go 51.45% <0.00%> (ø)
python 82.85% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @pabloem

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@jrmccluskey
Copy link
Contributor

Run Python_PVR_Flink PreCommit

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @jrmccluskey

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @pabloem for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @pabloem

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@tvalentyn
Copy link
Contributor

Run Python PreCommit

@tvalentyn
Copy link
Contributor

Run Python_Transforms PreCommit

1 similar comment
@tvalentyn
Copy link
Contributor

Run Python_Transforms PreCommit

@tvalentyn
Copy link
Contributor

retest this please

@tvalentyn
Copy link
Contributor

The remaining flake has been addressed in a different PR.

@tvalentyn
Copy link
Contributor

Thank you!

@tvalentyn tvalentyn merged commit c1b840a into apache:master Jan 19, 2023
@tjni tjni deleted the bump-httplib2 branch February 27, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax version of httplib2
3 participants