Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.python-redis-lock: disable tests for linux #212270

Closed
wants to merge 1 commit into from
Closed

python310Packages.python-redis-lock: disable tests for linux #212270

wants to merge 1 commit into from

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Jan 23, 2023

python310Packages.python-redis-lock: disable tests for linux

  • Tests are failing. See logs: https://termbin.com/5o7a
  • I couldn't fix tests. But it builds.
  • On attempting to fix tests, two missing dependencies fixed some tests but not all. So I'm including them.
  • As I cannot test/judge darwin, I'm only disabling tests for Linux.
  • Removes vanschelven from maintainers.

Upstream: https://github.com/ionelmc/python-redis-lock

@superherointj
Copy link
Contributor Author

@vanschelven Thoughts?

@vanschelven
Copy link
Contributor

the only thought I'm having is that I shouldn't be involved in this anymore 😄

feel free to remove me from the maintainers of this package, I'm not using it as part of my NixOS setup anymore which means I'm not giving it any attention anymore...

* Remove vanschelven as maintainer, as requested by him.
@superherointj
Copy link
Contributor Author

feel free to remove me from the maintainers of this package

Done. Feel free to review. :-)

@onny
Copy link
Contributor

onny commented Jan 25, 2023

Please rebase PR

@onny onny marked this pull request as draft January 25, 2023 09:56
erictapen added a commit to erictapen/nixpkgs that referenced this pull request Jul 4, 2024
Also remove a skipped test that just seems to work

Remove maintainer, as they asked for it here:
NixOS#212270 (comment)
erictapen added a commit to erictapen/nixpkgs that referenced this pull request Jul 11, 2024
Also remove a skipped test that just seems to work

Remove maintainer, as they asked for it here:
NixOS#212270 (comment)

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants