-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.python-redis-lock: fix tests for django support #325600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Jul 8, 2024
@ofborg build python3Packages.python-redis-locks |
erictapen
force-pushed
the
python-python-redis-lock
branch
from
July 8, 2024 22:37
81efb2a
to
3655ed0
Compare
@wegank I see, interesting. I reverted the formatting change. |
erictapen
force-pushed
the
python-python-redis-lock
branch
from
July 9, 2024 12:47
17a0edb
to
4caaae3
Compare
Please expose the django extra through |
Done. |
erictapen
force-pushed
the
python-python-redis-lock
branch
from
July 10, 2024 10:31
4caaae3
to
03ff6fd
Compare
mweinelt
reviewed
Jul 10, 2024
erictapen
force-pushed
the
python-python-redis-lock
branch
from
July 10, 2024 11:39
03ff6fd
to
1fd341c
Compare
Also remove a skipped test that just seems to work Remove maintainer, as they asked for it here: NixOS#212270 (comment) Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
erictapen
force-pushed
the
python-python-redis-lock
branch
from
July 11, 2024 11:25
1fd341c
to
1df8697
Compare
erictapen
changed the title
python3Packages.python-redis-locks: fix tests for withDjango = true
python3Packages.python-redis-locks: fix tests for django support
Jul 11, 2024
erictapen
changed the title
python3Packages.python-redis-locks: fix tests for django support
python3Packages.python-redis-lock: fix tests for django support
Jul 17, 2024
@GrahamcOfBorg build python3Packages.python-redis-lock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove a skipped test that just seems to work
Remove maintainer, as they asked for it here:
#212270 (comment)
Needed for #325541
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.