Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-redis-lock: fix tests for django support #325600

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Jul 8, 2024

Also remove a skipped test that just seems to work

Remove maintainer, as they asked for it here:
#212270 (comment)

Needed for #325541

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erictapen erictapen requested review from fabaff and wegank July 8, 2024 18:09
@erictapen erictapen mentioned this pull request Jul 8, 2024
13 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 8, 2024
@wegank
Copy link
Member

wegank commented Jul 8, 2024

@ofborg build python3Packages.python-redis-locks

@wegank
Copy link
Member

wegank commented Jul 8, 2024

By the way, it may soon be mandatory for files under pkgs/development/python-modules/ to be conformant with RFC 166 (see #324367), so I'm not sure if the reformatting is okay.

@erictapen erictapen force-pushed the python-python-redis-lock branch from 81efb2a to 3655ed0 Compare July 8, 2024 22:37
@erictapen
Copy link
Member Author

@wegank I see, interesting. I reverted the formatting change.

@erictapen erictapen force-pushed the python-python-redis-lock branch from 17a0edb to 4caaae3 Compare July 9, 2024 12:47
@mweinelt
Copy link
Member

mweinelt commented Jul 9, 2024

Please expose the django extra through optional-dependencies, remove withDjango and concat optional-depdenencies.django to nativeCheckInputs.

@erictapen
Copy link
Member Author

Done.

@erictapen erictapen force-pushed the python-python-redis-lock branch from 4caaae3 to 03ff6fd Compare July 10, 2024 10:31
@erictapen erictapen force-pushed the python-python-redis-lock branch from 03ff6fd to 1fd341c Compare July 10, 2024 11:39
Also remove a skipped test that just seems to work

Remove maintainer, as they asked for it here:
NixOS#212270 (comment)

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@erictapen erictapen force-pushed the python-python-redis-lock branch from 1fd341c to 1df8697 Compare July 11, 2024 11:25
@erictapen erictapen changed the title python3Packages.python-redis-locks: fix tests for withDjango = true python3Packages.python-redis-locks: fix tests for django support Jul 11, 2024
@erictapen erictapen changed the title python3Packages.python-redis-locks: fix tests for django support python3Packages.python-redis-lock: fix tests for django support Jul 17, 2024
@erictapen
Copy link
Member Author

@GrahamcOfBorg build python3Packages.python-redis-lock

@mweinelt mweinelt merged commit ff0584e into NixOS:master Jul 17, 2024
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants