-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zotero-dev: init at 7.0.0 #227053
zotero-dev: init at 7.0.0 #227053
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/2156 |
|
||
configurePhase = '' | ||
mkdir xulrunner | ||
cp -Lr ${firefox-esr-102-unwrapped}/lib/firefox xulrunner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cp -Lr ${firefox-esr-102-unwrapped}/lib/firefox xulrunner | |
cp -Lr ${firefox-esr-unwrapped}/lib/firefox xulrunner |
or do we need that exact version of firefox? I think the alias is going away with the next esr bump anyway and this would probably be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need Firefox 102 precisely, according to this: https://www.zotero.org/support/dev/zotero_7_for_developers. Is there another way to pin the version instead of the package name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then maybe we should use firefox-esr or add an overwrite for the firefox package but that might break over time, too as some conditionals for old firefox's are sometimes removed. Maintaining old versions of programs is an extra maintenance burden since they collect incompatibilities with other libraries over time.
So I don't really have a good solution here.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that the application is working as intended on my aarch64-linux machine
Zotero 7's main dependency, Firefox ESR 102, is already deprecated before Zotero is even released, so this has become unmergeable. I am thinking of moving this to a flake, if there are users interested in support for aarch64 or building Zotero from source. |
Description of changes
Builds Zotero from source instead of pre-built bundle. This fixes #201454 (compatibility with aarch64-linux).
Since Zotero 6 relies on Firefox 60 which is deprecated, this builds Zotero 7 (Firefox 102) which is still in development, so for now it could stay as draft and replace current
zotero
package once production-ready, or be merged and maintained aszotero-dev
so that people from Nix community may contribute to Zotero.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)