Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zotero-dev: init at 7.0.0 #227053

Closed
wants to merge 3 commits into from
Closed

Conversation

camillemndn
Copy link
Contributor

@camillemndn camillemndn commented Apr 19, 2023

Description of changes

Builds Zotero from source instead of pre-built bundle. This fixes #201454 (compatibility with aarch64-linux).

Since Zotero 6 relies on Firefox 60 which is deprecated, this builds Zotero 7 (Firefox 102) which is still in development, so for now it could stay as draft and replace current zotero package once production-ready, or be merged and maintained as zotero-dev so that people from Nix community may contribute to Zotero.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2156

pkgs/applications/office/zotero-dev/fetchxul.patch Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved

configurePhase = ''
mkdir xulrunner
cp -Lr ${firefox-esr-102-unwrapped}/lib/firefox xulrunner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -Lr ${firefox-esr-102-unwrapped}/lib/firefox xulrunner
cp -Lr ${firefox-esr-unwrapped}/lib/firefox xulrunner

or do we need that exact version of firefox? I think the alias is going away with the next esr bump anyway and this would probably be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need Firefox 102 precisely, according to this: https://www.zotero.org/support/dev/zotero_7_for_developers. Is there another way to pin the version instead of the package name?

Copy link
Member

@SuperSandro2000 SuperSandro2000 May 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe we should use firefox-esr or add an overwrite for the firefox package but that might break over time, too as some conditionals for old firefox's are sometimes removed. Maintaining old versions of programs is an extra maintenance burden since they collect incompatibilities with other libraries over time.
So I don't really have a good solution here.

pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
pkgs/applications/office/zotero-dev/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 changed the title zotero-dev: init at 7.0.0-096a3c5f2 zotero-dev: init at 7.0.0 May 7, 2023
camillemndn and others added 2 commits May 7, 2023 17:21
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Copy link
Member

@JulienMalka JulienMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the application is working as intended on my aarch64-linux machine

@camillemndn camillemndn closed this Oct 4, 2023
@camillemndn
Copy link
Contributor Author

Zotero 7's main dependency, Firefox ESR 102, is already deprecated before Zotero is even released, so this has become unmergeable. I am thinking of moving this to a flake, if there are users interested in support for aarch64 or building Zotero from source.

@camillemndn camillemndn deleted the zotero-dev branch October 4, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zotero installs x86_64 binaries on aarch64
4 participants