Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zotero: mark as insecure (CVE-2023-5217) #262808

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

i077
Copy link
Contributor

@i077 i077 commented Oct 22, 2023

Description of changes

Zotero 6 is based on Firefox 60 and has not patched this vulnerability. The next version is based on Firefox 102 (ESR) and has patched this, but is is still in beta.

See also #258048.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Zotero 6 is based on Firefox 60 and has not patched this vulnerability.
The next version is based on Firefox 102 (ESR) and has patched this, but
is is still in beta.

See also NixOS#258048.
@mweinelt mweinelt merged commit 4ef208f into NixOS:master Oct 22, 2023
4 of 5 checks passed
@mweinelt mweinelt added backport release-23.05 1.severity: security Issues which raise a security issue, or PRs that fix one labels Oct 22, 2023
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

@github-actions
Copy link
Contributor

Git push to origin failed for release-23.05 with exitcode 1

1 similar comment
@github-actions
Copy link
Contributor

Git push to origin failed for release-23.05 with exitcode 1

@i077 i077 deleted the zotero-insecure branch October 24, 2023 20:59
@shlevy
Copy link
Member

shlevy commented Oct 31, 2023

Should we open a ticket against upstream? Where did you see what firefox version Zotero is based on?

@i077
Copy link
Contributor Author

i077 commented Nov 1, 2023

I mentioned how I got the Firefox version in this comment in the CVE-tracking issue. It's been raised in the Zotero dev mailing list before. I just posted a response to the mailing list conversation, but it is now awaiting approval.

@camillemndn
Copy link
Contributor

Hi, for those interested, I managed to package Zotero 7 built from source in https://github.com/camillemndn/nixos-config/tree/main/pkgs/applications/office/zotero, but I could not upstream it since it is based on Firefox 102 which is already deprecated...

@shlevy
Copy link
Member

shlevy commented Nov 7, 2023

#266033

@shlevy
Copy link
Member

shlevy commented Nov 7, 2023

@camillemndn If nixpkgs would accept a binary build of Zotero based off of FF 102, it would be silly not to accept a source build based off the same.

@camillemndn
Copy link
Contributor

@camillemndn If nixpkgs would accept a binary build of Zotero based off of FF 102, it would be silly not to accept a source build based off the same.

I agree, maybe you can reopen #227053 when Zotero 7 is stable. I closed it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants