Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roadrunner: init at 2023.2.2 #227144

Merged
merged 1 commit into from
Aug 16, 2023
Merged

roadrunner: init at 2023.2.2 #227144

merged 1 commit into from
Aug 16, 2023

Conversation

shyim
Copy link
Member

@shyim shyim commented Apr 19, 2023

Description of changes

I want to use Roadrunner for my projects. So packaged also for Nixpkgs

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

drupol

This comment was marked as outdated.

@figsoda figsoda added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Apr 30, 2023
pkgs/servers/roadrunner/default.nix Outdated Show resolved Hide resolved
pkgs/servers/roadrunner/default.nix Outdated Show resolved Hide resolved
@drupol
Copy link
Contributor

drupol commented Aug 15, 2023

@shyim Do you think you could have a look at this PR at some point?

@shyim shyim changed the title roadrunner: init at 2023.1.0 roadrunner: init at 2023.2.2 Aug 15, 2023
@shyim
Copy link
Member Author

shyim commented Aug 15, 2023

New tests are failing, but I patched them and created a pull request upstream roadrunner-server/roadrunner#1680

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor changes and it's good to go!

pkgs/servers/roadrunner/default.nix Outdated Show resolved Hide resolved
pkgs/servers/roadrunner/default.nix Show resolved Hide resolved
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap,I forgot to ask you to add the meta.mainProgram attribute 🫤

@shyim
Copy link
Member Author

shyim commented Aug 16, 2023

Done :)

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@drupol drupol merged commit 15200d6 into NixOS:master Aug 16, 2023
7 of 8 checks passed
@shyim shyim deleted the add-roadrunner branch August 16, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants