Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test failures on darwin #1680

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

shyim
Copy link
Contributor

@shyim shyim commented Aug 15, 2023

Reason for This PR

Port 55555 is blocked for some reason on Darwin.

       > --- FAIL: TestNewClient_ConnectionError (0.00s)
       >     client_test.go:38:
       >         	Error Trace:	/private/tmp/nix-build-roadrunner-2023.2.2.drv-0/source/internal/rpc/client_test.go:38
       >         	Error:      	"dial tcp 127.0.0.1:0: connect: can't assign requested address" does not contain "connection refused"
       >         	Test:       	TestNewClient_ConnectionError
       > --- FAIL: TestNewClient_SuccessfullyConnected (0.00s)
       >     client_test.go:43:
       >         	Error Trace:	/private/tmp/nix-build-roadrunner-2023.2.2.drv-0/source/internal/rpc/client_test.go:43
       >         	Error:      	Received unexpected error:
       >         	            	listen tcp 127.0.0.1:55555: bind: address already in use
       >         	Test:       	TestNewClient_SuccessfullyConnected
       >     client_test.go:49:
       >         	Error Trace:	/private/tmp/nix-build-roadrunner-2023.2.2.drv-0/source/internal/rpc/client_test.go:49
       >         	Error:      	Expected value not to be nil.
       >         	Test:       	TestNewClient_SuccessfullyConnected
       >     client_test.go:50:
       >         	Error Trace:	/private/tmp/nix-build-roadrunner-2023.2.2.drv-0/source/internal/rpc/client_test.go:50
       >         	Error:      	Received unexpected error:
       >         	            	dial tcp 127.0.0.1:55555: connect: connection refused
       >         	Test:       	TestNewClient_SuccessfullyConnected

Also connecting to port 0 is not supported in Darwin:

       > --- FAIL: TestNewClient_ConnectionError (0.00s)
       >     client_test.go:38:
       >         	Error Trace:	/private/tmp/nix-build-roadrunner-2023.2.2.drv-0/source/internal/rpc/client_test.go:38
       >         	Error:      	"dial tcp 127.0.0.1:0: connect: can't assign requested address" does not contain "connection refused"
       >         	Test:       	TestNewClient_ConnectionError

Description of Changes

[Author TODO: add description of changes.]

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review August 15, 2023 20:26
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Aug 15, 2023
@rustatian
Copy link
Member

Hey @shyim 👋🏻
Yeah, according to the wiki, it's allocated by the BigSur and later. Good catch 👍🏻

@rustatian rustatian added this to the v2023.3.0 milestone Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1680 (7c8c781) into master (82cd320) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1680   +/-   ##
=======================================
  Coverage   38.00%   38.00%           
=======================================
  Files          16       16           
  Lines         842      842           
=======================================
  Hits          320      320           
  Misses        496      496           
  Partials       26       26           

Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shyim 👍🏻

@rustatian rustatian merged commit 99aed1f into roadrunner-server:master Aug 15, 2023
13 of 14 checks passed
@rustatian rustatian mentioned this pull request Aug 18, 2023
6 tasks
@rustatian rustatian mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Unreleased
Development

Successfully merging this pull request may close these issues.

2 participants