rustPlatform.rust: deprecate #230951
Merged
rustPlatform.rust: deprecate #230951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
added
the
6.topic: cross-compilation
github-actions
bot
added
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
8.has: documentation
alyssais
force-pushed
the
rustPlatform.rust-deprecate
branch
8 times, most recently
from
8c24662 to
65c40dc
Compare
ofborg
bot
added
10.rebuild-darwin: 0
alyssais
requested review from
thoughtpolice,
marsam,
ttuegel,
zowoq,
winterqt,
figsoda,
Mic92 and
adisbladis
as code owners
Ericson2314
approved these changes
May 11, 2023
|
rustPlatform.rust from the time where we also had nightly and beta channels build from source. Not having that is much nicer. |
mweinelt
added
the
12.approvals: 1
This will be deprecated in the next commit.
It is almost never correct to use these attributes, because they don't
work correctly with splicing. Compare:
% nix repl -f . --argstr crossSystem aarch64-linux
Welcome to Nix 2.10.3. Type :? for help.
Loading installable ''...
Added 18988 variables.
nix-repl> callPackage ({ stdenv, rustc }: (stdenv.mkDerivation { name = ""; nativeBuildInputs = [ rustc ]; }).nativeBuildInputs) {}
«derivation /nix/store/bjrkg8kcq3hvg5kb03ivb856zy91qpbk-aarch64-unknown-linux-gnu-rustc-1.69.0.drv» ]
nix-repl> callPackage ({ stdenv, rustPlatform }: (stdenv.mkDerivation { name = ""; nativeBuildInputs = [ rustPlatform.rust.rustc ]; }).nativeBuildInputs) {}
«derivation /nix/store/ra5r07j52y7akclr827r3dzxzvqnvfbl-rustc-1.69.0.drv» ]
I'm not sure this is fixable. I don't think it's worth keeping them
around considering we have top level attributes. It makes overriding
slightly more annoying, but only slightly.
alyssais
force-pushed
the
rustPlatform.rust-deprecate
branch
from
65c40dc to
d0f8e51
Compare
figsoda
added a commit
to figsoda/nixpkgs
that referenced
this pull request
May 12, 2023
rustPlatform.rust has been deprecated in NixOS#230951
winterqt
pushed a commit
that referenced
this pull request
May 12, 2023
rustPlatform.rust has been deprecated in #230951
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
It is almost never correct to use these attributes, because they don't work correctly with splicing. Compare:
I'm not sure this is fixable. I don't think it's worth keeping them around considering we have top level attributes. It makes overriding slightly more annoying, but only slightly.
I'm aiming for zero rebuilds with this. Draft until I get there.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)