Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustfmt: fix warning #231555

Merged
merged 1 commit into from
May 12, 2023
Merged

rustfmt: fix warning #231555

merged 1 commit into from
May 12, 2023

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented May 12, 2023

rustPlatform.rust has been deprecated in #230951

follow up to #231078

ofborg evals are failing because of the deprecation message

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

rustPlatform.rust has been deprecated in NixOS#230951
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What poor timing, definitely wasn't a good idea to ignore OfBorg 😄

@winterqt
Copy link
Member

winterqt commented May 12, 2023

Waiting on eval, not taking any chances this time.

@mweinelt
Copy link
Member

I think that's not going to cut it 🤡

@winterqt
Copy link
Member

No clue what could be failing at this point.

Let's... try again? Surely it'll be different.
@ofborg eval

@figsoda
Copy link
Member Author

figsoda commented May 12, 2023

ofborg-eval outputs all the rebuilds, so maybe it needs to eval both before and after this patch, and the warning could be from before this change

@winterqt
Copy link
Member

Good point... let's do it.

@winterqt winterqt merged commit 15f699f into NixOS:master May 12, 2023
@figsoda figsoda deleted the rustfmt branch May 12, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants