Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: 1.79 -> 1.81 #240604

Merged
merged 1 commit into from
Jul 15, 2023
Merged

boost: 1.79 -> 1.81 #240604

merged 1 commit into from
Jul 15, 2023

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jun 29, 2023

Description of changes

Updates boost to the most recent version minus one. The idea is to stay behind one release in the hope that most of the breakage caused by that version has been resolved in the upstreams in the meantime.

This also removes the boost17x and boost18x aliases. They suggested that the inner numbers 7 and 8 represent some kind of minor version, which is not the case.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tobim
Copy link
Contributor Author

tobim commented Jul 13, 2023

@wegank may I ask you for a review?

@wegank wegank mentioned this pull request Jul 13, 2023
12 tasks
@wegank
Copy link
Member

wegank commented Jul 13, 2023

I guess I don't have the computing power for the review, but I'll try to get the commit dropping boost17x and boost18x merged first.

@tobim
Copy link
Contributor Author

tobim commented Jul 14, 2023

I guess I don't have the computing power for the review

Isn't that one of the reasons staging exists?

@ofborg ofborg bot requested a review from prusnak July 14, 2023 11:22
@SuperSandro2000 SuperSandro2000 merged commit 2a947e5 into NixOS:staging Jul 15, 2023
@tjni tjni mentioned this pull request Jul 17, 2023
12 tasks
@vcunat
Copy link
Member

vcunat commented Jul 20, 2023

This is probably what broke all compiled libreoffice variants: https://hydra.nixos.org/build/228218374/nixlog/1/tail

/cc their maintainer @7c6f434c

@vcunat vcunat mentioned this pull request Jul 20, 2023
1 task
@SuperSandro2000
Copy link
Member

We can probably just use boost 1.79 for libre office

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants