arrow-cpp: fix build with clang 15+ #243530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to `cmake_modules/ThirdpartyToolchain.cmake`, arrow-cpp requires Boost 1.81+ when building with newer versions of clang.
ofborg
bot
added
10.rebuild-darwin: 0
tobim
approved these changes
Jul 14, 2023
| arrow-cpp = callPackage ../development/libraries/arrow-cpp { | ||
| # arrow-cpp requires Boost 1.81 or newer when building with clang 15+. | ||
| boost = if stdenv.cc.isClang && lib.versionAtLeast (lib.getVersion stdenv.cc) "15" | ||
| then boost18x else boost; |
There was a problem hiding this comment.
We dropped boost18x in #243286.
Suggested change
| then boost18x else boost; | |
| then boost181 else boost; |
There was a problem hiding this comment.
It also looks like #240604 will bump boost to 1.81, which is what arrow-cpp needs with clang 15+. In that case, this PR is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
According to
cmake_modules/ThirdpartyToolchain.cmake, arrow-cpp requires Boost 1.81+ when building with newer versions of clang.Build was tested with a clang 16 stdenv on Darwin.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)