-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/monado: init #245005
nixos/monado: init #245005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested but diff looks pretty good to me.
A couple things:
29dba97
to
67d5332
Compare
67d5332
to
36bc68a
Compare
36bc68a
to
a62be74
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3097 |
a62be74
to
a237444
Compare
It would be nice if the service would also set a symlink for |
The |
Edit: Got it working! :D |
476f52c
to
3df6e04
Compare
3df6e04
to
a6c065e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to enable the user socket manually after switch (a general NixOS issue I believe) and explicitly declare the XR runtime but was then able to run xrgears
:
XR_RUNTIME_JSON=/run/current-system/sw/share/openxr/1/openxr_monado.json xrgears
A few nits, questions and remarks.
Hold on, just hit this:
The socket should probably be configured to get back up in this case. |
23f8f2d
to
e0fce33
Compare
The security wrapper for |
02a6b3f
to
6587f4a
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3416 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nixpkgs-xr-nightly-packages-for-xr-ar-vr-tools-and-apps/40083/1 |
6587f4a
to
b6bba2f
Compare
I had intended to test this but had not found the time yet. If I haven't tested in a week, please ping me again and I'll just merge because the diff does LGTM. |
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
b6bba2f
to
3f7e9ba
Compare
Hey would it be possible for you to add an option to compile monado with basalt for wmr controller tracking? I tried to package it myself and failed. |
I could look into it, but it wouldn't be in scope for this PR I think |
Okay, thank you. I'll look into it a bit more myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thank you so much!
I was able to get a build of monado's version of basalt here, it uses an older version of pangolin, and some packages that aren't packaged in nix like Sophus. I just need to test it with monado to see if it is actually working. |
Description of changes
Closes #275107
This module ensures that we have a monado.service that has CAP_SYS_NICE to utilize asynchronous reprojection. (See #217119) for details about asynchronous reprojection)
This effectively shadows the unit files packaged in
monado
. Maybe it is desirable to remove those from the packages.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)