Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: fix passthru.tests #247520

Merged
merged 2 commits into from
Aug 8, 2023
Merged

kernel: fix passthru.tests #247520

merged 2 commits into from
Aug 8, 2023

Commits on Aug 6, 2023

  1. all-tests: exclude passthru attributes from test discovery 

    discoverTests tries to discover some sort of internal function and tries to call
it with the arguments for that internal function. This poses an issue when you
want to expose some other functions (i.e. a parameterisation for a test) in
nixosTests.

This commit allows a test to pass through arbitrary values via `.passthru`
without them having discovery applied to them; including functions.
    @Atemu
    Atemu committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    6229f0b View commit details
    Browse the repository at this point in the history

  2. kernel: fix passthru.tests 

    NixOS#191540 indirectly broke kernel
passthru.tests; calling the testsForLinuxPackages and testsForKernel functions
with some args intended for some other exposed test-internal function.

Organise the passed-through functions under `passthru` to prevent this from
happening.
    @Atemu
    Atemu committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    a0dcabb View commit details
    Browse the repository at this point in the history