Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.torch: Allow CUDA 8.7 #249250

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

hacker1024
Copy link
Member

@hacker1024 hacker1024 commented Aug 15, 2023

Description of changes

This PR adds CUDA 8.7 capabilities to the PyTorch whitelist. While 8.7 has not been added to the place linked in the comment, it is still accepted by PyTorch. See: pytorch/pytorch#94438 and the PRs that follow.

Built and tested on an NVIDIA Jetson Orin NX with CUDA from jetpack-nixos.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 15, 2023
@hacker1024 hacker1024 requested a review from ConnorBaker August 16, 2023 03:22
@ConnorBaker ConnorBaker requested review from SomeoneSerge and a team August 16, 2023 05:47
@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Aug 16, 2023
@ConnorBaker ConnorBaker self-assigned this Aug 16, 2023
@ConnorBaker
Copy link
Contributor

@SomeoneSerge with your okay I'll merge this. Very tiny change, just want another person's eyes on it.

@ConnorBaker
Copy link
Contributor

Thanks for the second set of eyes Samuel!

And thank you @hacker1024 for the submission :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cuda Parallel computing platform and API 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants