Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.torch: patch cpp_extension.py for Jetson support #266081

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Nov 7, 2023

Description of changes

Adds support for Jetson, part 2.

When I reviewed #249250 I forgot to mention that a Python file in-tree needed to be patched to match. This should resolve errors where PyTorch, at runtime, fails because the CUDA capability isn't whitelisted.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ConnorBaker ConnorBaker changed the title python3Packages.torch: fixups for Jetson python3Packages.torch: patch cpp_extension.py for Jetson support Nov 7, 2023
@ConnorBaker ConnorBaker self-assigned this Nov 7, 2023
@ConnorBaker ConnorBaker added the 6.topic: cuda Parallel computing platform and API label Nov 7, 2023
@ConnorBaker ConnorBaker marked this pull request as ready for review November 8, 2023 00:26
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2023
@ConnorBaker ConnorBaker merged commit 47f07ca into NixOS:master Nov 9, 2023
6 checks passed
@ConnorBaker ConnorBaker deleted the fix/torch-jetson branch November 9, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cuda Parallel computing platform and API 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants