Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocketchat-desktop: 3.9.8 -> 3.9.9 #259038

Merged
merged 1 commit into from
Oct 9, 2023
Merged

rocketchat-desktop: 3.9.8 -> 3.9.9 #259038

merged 1 commit into from
Oct 9, 2023

Conversation

gbtb
Copy link
Member

@gbtb gbtb commented Oct 4, 2023

Description of changes

Updated to version 3.9.9 which includes patched Electron
#258048

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 4, 2023
@xyzeva xyzeva mentioned this pull request Oct 4, 2023
Open
65 tasks
@MikaelFangel
Copy link
Contributor

Result from nixpkgs review:
1 package built:
rocketchat-desktop

@MikaelFangel MikaelFangel added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 9, 2023
@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 9, 2023
LeSuisse
LeSuisse approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Builds" and from a quick testing it seems to work.

Result of nixpkgs-review pr 259038 run on x86_64-linux 1

1 package built:
  • rocketchat-desktop

@LeSuisse LeSuisse merged commit 36418a2 into NixOS:master Oct 9, 2023
29 checks passed
@LeSuisse LeSuisse removed the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 9, 2023
@LeSuisse
Copy link
Contributor

LeSuisse commented Oct 9, 2023

Backport to stable: #260041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelFangel MikaelFangel MikaelFangel approved these changes

@LeSuisse LeSuisse LeSuisse approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbtb @MikaelFangel @LeSuisse