Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.05] rocketchat-desktop: 3.9.7 -> 3.9.9 #260041

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[23.05] rocketchat-desktop: 3.9.7 -> 3.9.9 #260041

merged 2 commits into from
Oct 12, 2023

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Oct 9, 2023

Description of changes

Related to #258048

https://github.com/RocketChat/Rocket.Chat.Electron/releases/tag/3.9.9
https://github.com/RocketChat/Rocket.Chat.Electron/releases/tag/3.9.8

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

r-ryantm and others added 2 commits October 9, 2023 20:37
@r-ryantm @LeSuisse
rocketchat-desktop: 3.9.7 -> 3.9.8
456d54f 
(cherry picked from commit ab4c206)
@gbtb @LeSuisse
rocketchat-desktop: 3.9.8 -> 3.9.9
52ecd71 
(cherry picked from commit bf591aa)
@LeSuisse LeSuisse added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 9, 2023
@LeSuisse LeSuisse mentioned this pull request Oct 9, 2023
Merged
12 tasks
@ofborg ofborg bot requested a review from gbtb October 9, 2023 19:27
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 9, 2023
@wegank wegank merged commit 51f5ec0 into NixOS:release-23.05 Oct 12, 2023
25 checks passed
@LeSuisse LeSuisse deleted the rocketchat-desktop-3.9.9-23.05 branch October 13, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbtb gbtb Awaiting requested review from gbtb

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LeSuisse @wegank @r-ryantm @gbtb