Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temurin-bin: init at 21 #259820

Merged
merged 2 commits into from
Oct 29, 2023
Merged

temurin-bin: init at 21 #259820

merged 2 commits into from
Oct 29, 2023

Conversation

Infinidoge
Copy link
Contributor

Description of changes

Adds temurin-bin-21.
This PR is a draft because Temurin hasn't actually released a version for JDK 21 yet.
When I get the chance, I'll go ahead and grab the early access version so people can test it, then replace it with the official version when it releases.

This PR was split from #258507 so OfBorg could evaluate the OpenJDK update without being hung up on the missing temurin-bin-21. (Plus, it means the OpenJDK update could be merged while we wait for Temurin, and this PR could update the bootstrap JDK of 21 from temurin-bin-20.)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Infinidoge Infinidoge force-pushed the feat/temurin-bin-21 branch from 93b460a to b663cf8 Compare October 8, 2023 18:52
@Infinidoge Infinidoge marked this pull request as draft October 8, 2023 18:56
@Infinidoge
Copy link
Contributor Author

In an update to their blog post, Adoptium just got the tests they needed for producing Temurin 21. Will be keeping an eye out for when it releases so I can finish up this PR.

@Infinidoge
Copy link
Contributor Author

For convenience sake, their tracking issue is here

@Infinidoge
Copy link
Contributor Author

Temurin bins for x86_64-linux, aarch64-linux, and aarch64-darwin have been published (plus Alpine versions of x86_64 and aarch64), so those are now in sources. Still waiting for x64_64-darwin and probably arm32-linux, so not marking as ready yet, but very close!

For those wanting to test it out, you can with flakes with

nix run github:Infinidoge/nixpkgs/feat/temurin-bin-21#temurin-bin-21

@Infinidoge
Copy link
Contributor Author

While the tracking issue chart hasn't been edited, the issue was closed, and based on the generated sources everything should be good to go!

@Infinidoge Infinidoge marked this pull request as ready for review October 25, 2023 13:42
@Infinidoge Infinidoge changed the title [DRAFT] temurin-bin: init at 21 temurin-bin: init at 21 Oct 25, 2023
@wegank wegank merged commit f4bc9a6 into NixOS:master Oct 29, 2023
10 checks passed
@Infinidoge Infinidoge deleted the feat/temurin-bin-21 branch October 29, 2023 15:04
@philiptaron philiptaron mentioned this pull request Apr 29, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants