temurin-bin: init at 22 and 23 #307783
Closed
temurin-bin: init at 22 and 23 #307783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python, a parenthesized expression is a tuple iff there is a comma between the parentheses. In order to have a 1-tuple, we need one more comma.
|
Collaborating with @Infinidoge on Matrix; closing this PR in favor of one they're crafting. 🔢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I followed the pattern of #259820 and added these outputs:
temurin-bin.jdk22temurin-bin.jdk23temurin-bin.jre22temurin-bin.jre23To do this, I ran the
pkgs/development/compilers/temurin-bin/generate-sources.pyscript, updating it to pull these versions as well. When reading the script, I noted an error in the declaration of theimplsvariable and fixed that as well.This causes an update for the rest of the prebuilt binaries as well, for the earlier JDKs.
Finally, I updated the names
temurin-binandtemurin-jre-binto the most recent version.This PR targets staging due to the rebuild count, but I did run a
nixpkgs-review rev HEADovernight and only saw build failures due to non-free software that needed to be manually fetched.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)