lib: add fromHexString #266705
Closed
lib: add fromHexString #266705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucasew <lucas59356@gmail.com>
ofborg
bot
added
10.rebuild-darwin: 0
infinisil
requested changes
Nov 13, 2023
| */ | ||
| fromHexString = value: | ||
| let | ||
| parsed = builtins.fromTOML "v=0x${value}"; |
There was a problem hiding this comment.
We should make sure to check for the limits of this approach. I recommend a single builtins.match "^[0-9a-fA-F]{,<maximum>}$" value to validate there's no invalid characters and not too many (fill in ). The current length limit should also be documented as a warning in the docs (see here), with a note that it could get increased in the future.
Comment on lines
+167
to
+170
| testFromHexStringSecondExample = { | ||
| expr = fromHexString (builtins.hashString "sha256" "test"); | ||
| expected = 9223372036854775807; | ||
| }; |
There was a problem hiding this comment.
This test will run into the length limit, needs some trimming :)
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
|
This PR can be closed since I cherry-picked the commit into #318712 |
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add a function that convert an hexadecimal string to it's int representation
Simplification of #258834
How to test:
nix-instantiate --eval lib/tests/misc.nixThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)