-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.xnd: fix python311 build with upstream patch #268058
Conversation
Fix renamed functions and moved header file. package builds and unit tests pass. Patch submitted upstream as https://github.com/xnd-project/xnd/pull/48
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. nixpkgs-review
happy, nixos x86_64 & aarch64-linux. Ofborg shows success on macos.
The package itself seems to build and run fine, but i cannot create a python environment with it. This is my tests in nixpkgs-review: $ nix-shell -I nixpkgs=nixpkgs/ -p 'python311.withPackages (ps: [ ps.xnd ps.pdoc ])' --run 'pdoc xnd'
error: collision between `/nix/store/zqwgj0cwr7ssi3jqh3jhbbsjv1kadmvf-python3.11-ndtypes-unstable-2019-08-01/include/docstrings.h' and `/nix/store/cvcwci3iplx07ln9k288ddaw7px29r23-python3.11-xnd-unstable-2019-08-01/include/docstrings.h' I'd like to move the header into the It seems this just got merged as i am writing this, so i'll look into it myself |
hmm. ndtypes and xnd are part of the same |
Generally libraries goes in UPDATE: #268337 |
Fix renamed functions and moved header file. package builds and unit tests pass. Patch submitted and merged upstream as
https://github.com/xnd-project/xnd/pull/48
ZHF #265948
https://hydra.nixos.org/build/239056417
Result of
nixpkgs-review pr 268058
run on x86_64-linux 18 packages built:
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)