Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.11 fixes #48

Merged
merged 1 commit into from Nov 17, 2023
Merged

python3.11 fixes #48

merged 1 commit into from Nov 17, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2023

python package builds and unittests succeed after the fix. see: NixOS/nixpkgs#268058

longintrepr.h moved but is included by Python.h

Functions renamed in python/cpython#31657
_PyFloat_Pack2 -> PyFloat_Pack2
_PyFloat_Pack4 -> PyFloat_Pack4
_PyFloat_Pack8 -> PyFloat_Pack8
_PyFloat_Unpack2 -> PyFloat_Unpack2
_PyFloat_Unpack4 -> PyFloat_Unpack4
_PyFloat_Unpack8 -> PyFloat_Unpack8

Copy link
Contributor

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change, otherwise LGTM.

python/xnd/util.h Show resolved Hide resolved
python package builds and unittests succeed after this fix

longintrepr.h moved but is included by Python.h

Functions renamed in python/cpython#31657
_PyFloat_Pack2   -> PyFloat_Pack2
_PyFloat_Pack4   -> PyFloat_Pack4
_PyFloat_Pack8   -> PyFloat_Pack8
_PyFloat_Unpack2 -> PyFloat_Unpack2
_PyFloat_Unpack4 -> PyFloat_Unpack4
_PyFloat_Unpack8 -> PyFloat_Unpack8
@hameerabbasi hameerabbasi merged commit e1a06d9 into xnd-project:master Nov 17, 2023
@hameerabbasi
Copy link
Contributor

Thanks for the contribution, @a-n-n-a-l-e-e!

@ghost ghost deleted the python311-fixes branch November 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant