Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hqplayer-desktop: unpin llvm-10 #283681

Merged
merged 1 commit into from Jan 25, 2024
Merged

hqplayer-desktop: unpin llvm-10 #283681

merged 1 commit into from Jan 25, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2024

Description of changes

removing the few packages still relying on llvm-10 in preparation to drop it from the tree.

this change unpins openmp to use the one from the default llvmPackages.

testing. x64 linux. built, played an mp3, queried with hqp-control2.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ghost ghost requested review from Et7f3 and lovesegfault January 25, 2024 06:48
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 25, 2024
@ghost
Copy link
Author

ghost commented Jan 25, 2024

PR #283631 already unpins

@ghost ghost closed this Jan 25, 2024
@ghost
Copy link
Author

ghost commented Jan 25, 2024

reopening due to #283631 not running on my amd 5700x

@ghost ghost reopened this Jan 25, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 25, 2024
Copy link
Contributor

@Et7f3 Et7f3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build on x86_64-linux

@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 25, 2024
@lovesegfault lovesegfault merged commit c02e516 into NixOS:master Jan 25, 2024
34 checks passed
@ghost ghost mentioned this pull request Jan 26, 2024
@ghost ghost deleted the hqplayer-desktop-unpin-llvm branch February 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants